Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Unified Diff: remoting/protocol/session_config.cc

Issue 10532211: Added piping for sending audio packets from host to client. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Updated documentation Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/protocol/session_config.cc
diff --git a/remoting/protocol/session_config.cc b/remoting/protocol/session_config.cc
index 528d96c400268959a7ef07d54421c6b4287c9f81..4d070f09b016304e86ee4fdeb215fdf3993da064 100644
--- a/remoting/protocol/session_config.cc
+++ b/remoting/protocol/session_config.cc
@@ -43,6 +43,9 @@ SessionConfig SessionConfig::GetDefault() {
result.set_video_config(ChannelConfig(ChannelConfig::TRANSPORT_STREAM,
kDefaultStreamVersion,
ChannelConfig::CODEC_VP8));
+ result.set_audio_config(ChannelConfig(ChannelConfig::TRANSPORT_STREAM,
+ kDefaultStreamVersion,
+ ChannelConfig::CODEC_UNDEFINED));
Wez 2012/06/22 18:29:53 Why is the default audio channel config "undefined
kxing 2012/06/22 19:12:31 Right, I meant CODEC_VERBATIM.
return result;
}
@@ -52,7 +55,8 @@ CandidateSessionConfig::CandidateSessionConfig(
const CandidateSessionConfig& config)
: control_configs_(config.control_configs_),
event_configs_(config.event_configs_),
- video_configs_(config.video_configs_) {
+ video_configs_(config.video_configs_),
+ audio_configs_(config.audio_configs_) {
}
CandidateSessionConfig::~CandidateSessionConfig() { }
@@ -63,19 +67,23 @@ bool CandidateSessionConfig::Select(
ChannelConfig control_config;
ChannelConfig event_config;
ChannelConfig video_config;
+ ChannelConfig audio_config;
if (!SelectCommonChannelConfig(
control_configs_, client_config->control_configs_, &control_config) ||
!SelectCommonChannelConfig(
event_configs_, client_config->event_configs_, &event_config) ||
!SelectCommonChannelConfig(
- video_configs_, client_config->video_configs_, &video_config)) {
+ video_configs_, client_config->video_configs_, &video_config) ||
+ !SelectCommonChannelConfig(
+ audio_configs_, client_config->audio_configs_, &audio_config)) {
return false;
}
result->set_control_config(control_config);
result->set_event_config(event_config);
result->set_video_config(video_config);
+ result->set_audio_config(audio_config);
return true;
}
@@ -85,19 +93,22 @@ bool CandidateSessionConfig::IsSupported(
return
IsChannelConfigSupported(control_configs_, config.control_config()) &&
IsChannelConfigSupported(event_configs_, config.event_config()) &&
- IsChannelConfigSupported(video_configs_, config.video_config());
+ IsChannelConfigSupported(video_configs_, config.video_config()) &&
+ IsChannelConfigSupported(audio_configs_, config.audio_config());
}
bool CandidateSessionConfig::GetFinalConfig(SessionConfig* result) const {
if (control_configs_.size() != 1 ||
event_configs_.size() != 1 ||
- video_configs_.size() != 1) {
+ video_configs_.size() != 1 ||
+ audio_configs_.size() != 1) {
return false;
}
result->set_control_config(control_configs_.front());
result->set_event_config(event_configs_.front());
result->set_video_config(video_configs_.front());
+ result->set_audio_config(audio_configs_.front());
return true;
}
@@ -142,6 +153,7 @@ scoped_ptr<CandidateSessionConfig> CandidateSessionConfig::CreateFrom(
result->mutable_control_configs()->push_back(config.control_config());
result->mutable_event_configs()->push_back(config.event_config());
result->mutable_video_configs()->push_back(config.video_config());
+ result->mutable_audio_configs()->push_back(config.audio_config());
return result.Pass();
}
@@ -160,6 +172,18 @@ scoped_ptr<CandidateSessionConfig> CandidateSessionConfig::CreateDefault() {
ChannelConfig(ChannelConfig::TRANSPORT_STREAM,
kDefaultStreamVersion,
ChannelConfig::CODEC_VP8));
+ result->mutable_audio_configs()->push_back(
+ ChannelConfig(ChannelConfig::TRANSPORT_NONE,
+ kDefaultStreamVersion,
+ ChannelConfig::CODEC_UNDEFINED));
+ result->mutable_audio_configs()->push_back(
+ ChannelConfig(ChannelConfig::TRANSPORT_STREAM,
+ kDefaultStreamVersion,
+ ChannelConfig::CODEC_VERBATIM));
+ result->mutable_audio_configs()->push_back(
+ ChannelConfig(ChannelConfig::TRANSPORT_STREAM,
+ kDefaultStreamVersion,
+ ChannelConfig::CODEC_VORBIS));
return result.Pass();
}
« remoting/protocol/content_description.cc ('K') | « remoting/protocol/session_config.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698