Rename back _linuxish to linux.

chrome/chrome_browser.gypi

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 #
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'targets': [
     {
       'target_name': 'browser',
       'type': 'static_library',
@@ skipping 4558 matching lines @@
             'libraries': [
               '-lXss',
             ],
           },
         }],
         ['os_posix == 1 and OS != "mac"', {
           'sources': [ 'browser/crash_handler_host_linuxish.h', ],
           'conditions': [
             ['linux_breakpad==1', {
               'sources': [
-                'app/breakpad_linuxish.cc',
-                'app/breakpad_linuxish.h',
-                'browser/crash_handler_host_linuxish.cc',
+                'app/breakpad_linux.cc',
+                'app/breakpad_linux.h',
+                'browser/crash_handler_host_linux.cc',
               ],
               'dependencies': [
                 '../breakpad/breakpad.gyp:breakpad_client',
                 # make sure file_version_info_linux.h is generated first.
                 'common',
               ],
               'include_dirs': [
-                # breakpad_linuxish.cc uses generated file_version_info_linux.h.
+                # breakpad_linux.cc uses generated file_version_info_linux.h.
                 '<(SHARED_INTERMEDIATE_DIR)',
                 '../breakpad/src',
               ],
             }, {  # linux_breakpad==0
               'sources': [
-                'browser/crash_handler_host_linuxish_stub.cc',
+                'browser/crash_handler_host_linux_stub.cc',
               ],
             }],
           ],
         }],
         ['use_aura==0', {
           'sources/': [
             ['exclude', '^browser/ui/webui/gesture_config_ui.cc'],
             ['exclude', '^browser/ui/webui/gesture_config_ui.h']
           ],
         }],
@@ skipping 545 matching lines @@
             ['exclude', '^browser/ui/gtk/select_file_dialog_impl_kde.cc'],
             ['include', '^browser/ui/views/select_file_dialog_extension.cc'],
             ['include', '^browser/ui/views/select_file_dialog_extension.h'],
           ]}, {
           'sources/': [
             ['exclude', '^browser/ui/views/select_file_dialog_extension.cc'],
             ['exclude', '^browser/ui/views/select_file_dialog_extension.h'],
           ]}
         ],
       ],
+      'target_conditions': [
+        # We need 'target_conditions' to override default filename_rules

[Mark Mentovai, 2012/06/21 14:49:38]

Don’t use “we” in comments.

[Xianzhu, 2012/06/24 04:04:48]

Done.

+        # to include the files on Android.
+        ['OS=="android"', {
+          'sources': [
+            ['include', '^app/breakpad_linux.cc'],

[Mark Mentovai, 2012/06/21 14:49:38]

Since you’re using regular expressions, use proper RE format:

Put a backslash before the dot.

Put a $ at the end of the pattern.

[Xianzhu, 2012/06/24 04:04:48]

I used \\. and $ in the previous change set, but now I'm keeping consistent with
other regexps in this file (there is only one with \\. and $, while 245 others
without). Either one looks good to me.  I will be glad to add them if you still
think it's better to have them.

[Mark Mentovai, 2012/06/24 12:33:15]

Xianzhu wrote:
It is better to have them. That’s why I asked for them.

[Xianzhu, 2012/06/26 11:49:27]

Should we file a bug to add them elsewhere?

On 2012/06/24 12:33:15, Mark Mentovai wrote:

+            ['include', '^browser/crash_handler_host_linux.cc'],
+            ['include', '^browser/crash_handler_host_linux_stub.cc'],
+          ],
+        }],
+      ],
     },
     {
       'target_name': 'autofill_regexes',
       'type': 'none',
       'actions': [{
         'action_name': 'autofill_regexes',
         'inputs': [
           '<(DEPTH)/build/escape_unicode.py',
           'browser/autofill/autofill_regex_constants.cc.utf8',
         ],
@@ skipping 80 matching lines @@
         'browser/metrics/proto/study.proto',
       ],
       'variables': {
         'proto_in_dir': 'browser/metrics/proto',
         'proto_out_dir': 'chrome/browser/metrics/proto',
       },
       'includes': [ '../build/protoc.gypi' ]
     },
   ],
 }