Added support for icon views (view used instead of icon in a menu item).

ui/views/controls/menu/menu_item_view.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_CONTROLS_MENU_MENU_ITEM_VIEW_H_
 #define UI_VIEWS_CONTROLS_MENU_MENU_ITEM_VIEW_H_
 #pragma once
 
 #include <string>
 #include <vector>
@@ skipping 222 matching lines @@
   // Sets the |tooltip| for a menu item view with |item_id| identifier.
   void SetTooltip(const string16& tooltip, int item_id);
 
   // Sets the icon for the descendant identified by item_id.
   void SetIcon(const gfx::ImageSkia& icon, int item_id);
 
   // Sets the icon of this menu item.
   void SetIcon(const gfx::ImageSkia& icon);
 
   // Returns the icon.
-  const gfx::ImageSkia& GetIcon() const { return icon_; }
+  const gfx::ImageSkia& GetIcon();

[sky, 2012/06/20 21:52:40]

I would just assume remove this. Do we actually need it?

[yefimt, 2012/06/22 22:14:40]

Removed
On 2012/06/20 21:52:40, sky wrote:

+
+  // Set/Get a View to be used instead of icon.
+  // It always be inserted as a first child view.

[sky, 2012/06/20 21:52:40]

How about:
Sets the view used to render the icon. This clobbers any icon set via SetIcon().
MenuItemView takes ownership of |icon_view|.

Is it really necessary to mention how the child is added?

[yefimt, 2012/06/22 22:14:40]

Done.

+  void SetIconView(View* icon_view);
+  View* GetIconView();
 
   // Sets the command id of this menu item.
   void SetCommand(int command) { command_ = command; }
 
   // Returns the command id of this item.
   int GetCommand() const { return command_; }
 
   // Paints the menu item.
   virtual void OnPaint(gfx::Canvas* canvas) OVERRIDE;
 
@@ skipping 49 matching lines @@
   // level only).
   void set_menu_position(MenuPosition menu_position) {
     requested_menu_position_ = menu_position;
   }
 
   // Suppress the right margin if this is set to false.
   void set_use_right_margin(bool use_right_margin) {
     use_right_margin_ = use_right_margin;
   }
 
+  virtual Border* GetMenuBorder();

[sky, 2012/06/20 21:52:40]

Descriptions.

[yefimt, 2012/06/22 22:14:40]

Done.

+  virtual Background* GetMenuBackground();
+
  protected:
   // Creates a MenuItemView. This is used by the various AddXXX methods.
   MenuItemView(MenuItemView* parent, int command, Type type);
 
   // MenuRunner owns MenuItemView and should be the only one deleting it.
   virtual ~MenuItemView();
 
   virtual void ChildPreferredSizeChanged(View* child) OVERRIDE;
 
   virtual std::string GetClassName() const OVERRIDE;
 
  private:
   friend class internal::MenuRunnerImpl;  // For access to ~MenuItemView.
 
   // Calculates all sizes that we can from the OS.
   //
   // This is invoked prior to Running a menu.
-  static void UpdateMenuPartSizes(bool has_icons);
+  void UpdateMenuPartSizes();
 
   // Called by the two constructors to initialize this menu item.
   void Init(MenuItemView* parent,
             int command,
             MenuItemView::Type type,
             MenuDelegate* delegate);
 
   // The RunXXX methods call into this to set up the necessary state before
   // running.
   void PrepareForRun(bool has_mnemonics, bool show_mnemonics);
@@ skipping 57 matching lines @@
   void set_actual_menu_position(MenuPosition actual_menu_position) {
     actual_menu_position_ = actual_menu_position;
   }
 
   void set_controller(MenuController* controller) { controller_ = controller; }
 
   // Returns true if this MenuItemView contains a single child
   // that is responsible for rendering the content.
   bool IsContainer() const;
 
+  // Returns true if menu item has non icon view child.
+  bool HasNonIconChildViews();
+
   // The delegate. This is only valid for the root menu item. You shouldn't
   // use this directly, instead use GetDelegate() which walks the tree as
   // as necessary.
   MenuDelegate* delegate_;
 
   // The controller for the run operation, or NULL if the menu isn't showing.
   MenuController* controller_;
 
   // Used to detect when Cancel was invoked.
   bool canceled_;
@@ skipping 10 matching lines @@
 
   // Command id.
   int command_;
 
   // Submenu, created via CreateSubmenu.
   SubmenuView* submenu_;
 
   // Title.
   string16 title_;
 
-  // Icon.
-  gfx::ImageSkia icon_;
+  // Empty icon.
+  static gfx::ImageSkia empty_icon_;

[sky, 2012/06/20 21:52:40]

No static objects.

[yefimt, 2012/06/22 22:14:40]

removed
On 2012/06/20 21:52:40, sky wrote:

 
   // Does the title have a mnemonic? Only useful on the root menu item.
   bool has_mnemonics_;
 
   // Should we show the mnemonic? Mnemonics are shown if this is true or
   // MenuConfig says mnemonics should be shown. Only used on the root menu item.
   bool show_mnemonics_;
 
+  // Set if menu has icons or icon_views
+  // (applies to root menu item only).
   bool has_icons_;
 
+  enum IconViewType {

[sky, 2012/06/20 21:52:40]

Move enum to top of section.

[yefimt, 2012/06/22 22:14:40]

removed
On 2012/06/20 21:52:40, sky wrote:

+    NONE,
+    IMAGE_VIEW,
+    SOME_VIEW

[sky, 2012/06/20 21:52:40]

HA! Rather than the enum have an explicit icon_view_ member of type view. Better
type safety anyway.

[yefimt, 2012/06/22 22:14:40]

Done.

+  };
+  // Type of an icon view.
+  IconViewType icon_view_type_;
+
   // The tooltip to show on hover for this menu item.
   string16 tooltip_;
 
+  static int icon_width_;

[sky, 2012/06/20 21:52:40]

Add a description.

[yefimt, 2012/06/22 22:14:40]

Done.

+
   // X-coordinate of where the label starts.
   static int label_start_;
 
   // Margins between the right of the item and the label.
   static int item_right_margin_;
 
   // Preferred height of menu items. Reset every time a menu is run.
   static int pref_menu_height_;
 
   // Previously calculated preferred size to reduce GetStringWidth calls in
@@ skipping 16 matching lines @@
   // If set to false, the right margin will be removed for menu lines
   // containing other elements.
   bool use_right_margin_;
 
   DISALLOW_COPY_AND_ASSIGN(MenuItemView);
 };
 
 }  // namespace views
 
 #endif  // UI_VIEWS_CONTROLS_MENU_MENU_ITEM_VIEW_H_