Added support for icon views (view used instead of icon in a menu item).

ui/views/controls/menu/menu_item_view.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_CONTROLS_MENU_MENU_ITEM_VIEW_H_
 #define UI_VIEWS_CONTROLS_MENU_MENU_ITEM_VIEW_H_
 #pragma once
 
 #include <string>
 #include <vector>
@@ skipping 224 matching lines @@
 
   // Sets the icon for the descendant identified by item_id.
   void SetIcon(const gfx::ImageSkia& icon, int item_id);
 
   // Sets the icon of this menu item.
   void SetIcon(const gfx::ImageSkia& icon);
 
   // Returns the icon.
   const gfx::ImageSkia& GetIcon() const { return icon_; }
 
+  // Set/Get a View to be used instead of icon.
+  // It always be inserted as a first child view.
+  void SetIconView(View* icon_view);
+  View* GetIconView();

[Aaron Boodman, 2012/06/19 00:06:33]

If these are just simple getters and setters, the correct style would be:

void set_icon_view(...)
View* icon_view() const;

[Aaron Boodman, 2012/06/19 21:45:38]

Nevermind, I forgot to remove this comment.

+
   // Sets the command id of this menu item.
   void SetCommand(int command) { command_ = command; }
 
   // Returns the command id of this item.
   int GetCommand() const { return command_; }
 
   // Paints the menu item.
   virtual void OnPaint(gfx::Canvas* canvas) OVERRIDE;
 
   // Returns the preferred size of this item.
@@ skipping 15 matching lines @@
   // Returns the mnemonic for this MenuItemView, or 0 if this MenuItemView
   // doesn't have a mnemonic.
   char16 GetMnemonic();
 
   // Do we have icons? This only has effect on the top menu. Turning this on
   // makes the menus slightly wider and taller.
   void set_has_icons(bool has_icons) {
     has_icons_ = has_icons;
   }
 
+  void set_has_icon_views(bool has_icon_views) {
+    has_icon_views_ = has_icon_views;
+  }
+
   // Returns the descendant with the specified command.
   MenuItemView* GetMenuItemByID(int id);
 
   // Invoke if you remove/add children to the menu while it's showing. This
   // recalculates the bounds.
   void ChildrenChanged();
 
   // Sizes any child views.
   virtual void Layout() OVERRIDE;
 
@@ skipping 13 matching lines @@
   // level only).
   void set_menu_position(MenuPosition menu_position) {
     requested_menu_position_ = menu_position;
   }
 
   // Suppress the right margin if this is set to false.
   void set_use_right_margin(bool use_right_margin) {
     use_right_margin_ = use_right_margin;
   }
 
+  virtual Border* GetMenuBorder();
+  virtual Background* GetMenuBackground();
+
  protected:
   // Creates a MenuItemView. This is used by the various AddXXX methods.
   MenuItemView(MenuItemView* parent, int command, Type type);
 
   // MenuRunner owns MenuItemView and should be the only one deleting it.
   virtual ~MenuItemView();
 
   virtual void ChildPreferredSizeChanged(View* child) OVERRIDE;
 
   virtual std::string GetClassName() const OVERRIDE;
 
+  // Calculates all sizes that we can from the OS.
+  //
+  // This is invoked prior to Running a menu.
+  void UpdateMenuPartSizes();
+
  private:
   friend class internal::MenuRunnerImpl;  // For access to ~MenuItemView.
 
-  // Calculates all sizes that we can from the OS.
-  //
-  // This is invoked prior to Running a menu.
-  static void UpdateMenuPartSizes(bool has_icons);
-
   // Called by the two constructors to initialize this menu item.
   void Init(MenuItemView* parent,
             int command,
             MenuItemView::Type type,
             MenuDelegate* delegate);
 
   // The RunXXX methods call into this to set up the necessary state before
   // running.
   void PrepareForRun(bool has_mnemonics, bool show_mnemonics);
 
@@ skipping 56 matching lines @@
   void set_actual_menu_position(MenuPosition actual_menu_position) {
     actual_menu_position_ = actual_menu_position;
   }
 
   void set_controller(MenuController* controller) { controller_ = controller; }
 
   // Returns true if this MenuItemView contains a single child
   // that is responsible for rendering the content.
   bool IsContainer() const;
 
+  // Returns true if menu item has non icon view child.
+  bool HasNonIconChildViews();
+
   // The delegate. This is only valid for the root menu item. You shouldn't
   // use this directly, instead use GetDelegate() which walks the tree as
   // as necessary.
   MenuDelegate* delegate_;
 
   // The controller for the run operation, or NULL if the menu isn't showing.
   MenuController* controller_;
 
   // Used to detect when Cancel was invoked.
   bool canceled_;
@@ skipping 20 matching lines @@
   // Icon.
   gfx::ImageSkia icon_;
 
   // Does the title have a mnemonic? Only useful on the root menu item.
   bool has_mnemonics_;
 
   // Should we show the mnemonic? Mnemonics are shown if this is true or
   // MenuConfig says mnemonics should be shown. Only used on the root menu item.
   bool show_mnemonics_;
 
+  // One of them is set if menu has icons or icon_views
+  // (applies to root menu item only).
   bool has_icons_;
+  bool has_icon_views_;
+
+  // Menu item has icon view
+  bool has_icon_view_;
 
   // The tooltip to show on hover for this menu item.
   string16 tooltip_;
 
   // X-coordinate of where the label starts.
   static int label_start_;
 
   // Margins between the right of the item and the label.
   static int item_right_margin_;
 
@@ skipping 20 matching lines @@
   // If set to false, the right margin will be removed for menu lines
   // containing other elements.
   bool use_right_margin_;
 
   DISALLOW_COPY_AND_ASSIGN(MenuItemView);
 };
 
 }  // namespace views
 
 #endif  // UI_VIEWS_CONTROLS_MENU_MENU_ITEM_VIEW_H_