Added support for icon views (view used instead of icon in a menu item).

ui/views/controls/menu/menu_item_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/menu/menu_item_view.h"
 
 #include "base/i18n/case_conversion.h"
 #include "base/stl_util.h"
 #include "base/utf_string_conversions.h"
 #include "grit/ui_strings.h"
@@ skipping 68 matching lines @@
       controller_(NULL),
       canceled_(false),
       parent_menu_item_(NULL),
       type_(SUBMENU),
       selected_(false),
       command_(0),
       submenu_(NULL),
       has_mnemonics_(false),
       show_mnemonics_(false),
       has_icons_(false),
+      has_icon_views_(false),

[Aaron Boodman, 2012/06/19 00:06:33]

I don't see where has_icon_views_ is ever assigned to. It's always false?

[yefimt, 2012/06/20 16:53:04]

There is a set function in an h file

On 2012/06/19 00:06:33, Aaron Boodman wrote:

+      has_icon_view_(false),
       top_margin_(-1),
       bottom_margin_(-1),
       requested_menu_position_(POSITION_BEST_FIT),
       actual_menu_position_(requested_menu_position_),
       use_right_margin_(true) {
   // NOTE: don't check the delegate for NULL, UpdateMenuPartSizes supplies a
   // NULL delegate.
   Init(NULL, 0, SUBMENU, delegate);
 }
 
@@ skipping 248 matching lines @@
   SchedulePaint();
 }
 
 void MenuItemView::SetTooltip(const string16& tooltip, int item_id) {
   MenuItemView* item = GetMenuItemByID(item_id);
   DCHECK(item);
   item->tooltip_ = tooltip;
 }
 
 void MenuItemView::SetIcon(const gfx::ImageSkia& icon, int item_id) {
+  DCHECK(!has_icon_view_);
   MenuItemView* item = GetMenuItemByID(item_id);
   DCHECK(item);
   item->SetIcon(icon);
 }
 
 void MenuItemView::SetIcon(const gfx::ImageSkia& icon) {

[Aaron Boodman, 2012/06/19 00:06:33]

Is it possible to reimplement SetIcon() in terms of SetIconView()? (e.g., by
creating an ImageView and passing it to SetIconView).

[yefimt, 2012/06/20 16:53:04]

Done.

+  DCHECK(!has_icon_view_);
   icon_ = icon;
   SchedulePaint();
 }
 
+void MenuItemView::SetIconView(View* icon_view) {
+  DCHECK(icon_view);
+  DCHECK(icon_.empty());
+  AddChildViewAt(icon_view, 0);
+  has_icon_view_ = true;
+}
+
+View* MenuItemView::GetIconView() {
+  if (!has_icon_view_)
+    return NULL;
+
+  return child_at(0);
+}
+
 void MenuItemView::OnPaint(gfx::Canvas* canvas) {
   PaintButton(canvas, PB_NORMAL);
 }
 
 gfx::Size MenuItemView::GetPreferredSize() {
   if (pref_size_.IsEmpty())
     pref_size_ = CalculatePreferredSize();
   return pref_size_;
 }
 
@@ skipping 95 matching lines @@
     return;
 
   if (IsContainer()) {
     View* child = child_at(0);
     gfx::Size size = child->GetPreferredSize();
     child->SetBounds(0, GetTopMargin(), size.width(), size.height());
   } else {
     // Child views are laid out right aligned and given the full height. To
     // right align start with the last view and progress to the first.
     int x = width() - (use_right_margin_ ? item_right_margin_ : 0);
-    for (int i = child_count() - 1; i >= 0; --i) {
+    int last_right_side_child = has_icon_view_ ? 1 : 0;

[Aaron Boodman, 2012/06/19 00:06:33]

naming suggestion: first_non_icon_view.

[yefimt, 2012/06/20 16:53:04]

Done.

+    for (int i = child_count() - 1; i >= last_right_side_child; --i) {
       View* child = child_at(i);
       int width = child->GetPreferredSize().width();
       child->SetBounds(x - width, 0, width, height());
       x -= width - kChildXPadding;
     }
+    // Position icon_view
+    if (has_icon_view_) {
+      View* child = child_at(0);
+      child->SetPosition(gfx::Point(0,0));
+      child->SizeToPreferredSize();
+    }
   }
 }
 
 int MenuItemView::GetAcceleratorTextWidth() {
   string16 text = GetAcceleratorText();
   return text.empty() ? 0 : GetFont().GetStringWidth(text);
 }
 
 void MenuItemView::SetMargins(int top_margin, int bottom_margin) {
   top_margin_ = top_margin;
   bottom_margin_ = bottom_margin;
 
   // invalidate GetPreferredSize() cache
   pref_size_.SetSize(0,0);
 }
 
+Border* MenuItemView::GetMenuBorder() {
+  return Border::CreateEmptyBorder(
+             MenuConfig::instance().submenu_vertical_margin_size,
+             MenuConfig::instance().submenu_horizontal_margin_size,
+             MenuConfig::instance().submenu_vertical_margin_size,
+             MenuConfig::instance().submenu_horizontal_margin_size);
+}
+
+Background* MenuItemView::GetMenuBackground() {
+  return NULL;
+}
+
 MenuItemView::MenuItemView(MenuItemView* parent,
                            int command,
                            MenuItemView::Type type)
     : delegate_(NULL),
       controller_(NULL),
       canceled_(false),
       parent_menu_item_(parent),
       type_(type),
       selected_(false),
       command_(command),
       submenu_(NULL),
       has_mnemonics_(false),
       show_mnemonics_(false),
       has_icons_(false),
+      has_icon_views_(false),
+      has_icon_view_(false),
       top_margin_(-1),
       bottom_margin_(-1),
       requested_menu_position_(POSITION_BEST_FIT),
       actual_menu_position_(requested_menu_position_) {
   Init(parent, command, type, NULL);
 }
 
 MenuItemView::~MenuItemView() {
   delete submenu_;
   STLDeleteElements(&removed_items_);
 }
 
 std::string MenuItemView::GetClassName() const {
   return kViewClassName;
 }
 
 // Calculates all sizes that we can from the OS.
 //
 // This is invoked prior to Running a menu.
-void MenuItemView::UpdateMenuPartSizes(bool has_icons) {
+void MenuItemView::UpdateMenuPartSizes() {
   MenuConfig::Reset();
   const MenuConfig& config = MenuConfig::instance();
 
   item_right_margin_ = config.label_to_arrow_padding + config.arrow_width +
                        config.arrow_to_edge_padding;
+  int icon_width = config.check_width;
+  if (has_icon_views_) {
+    for (int i = 0; i < submenu_->GetMenuItemCount(); ++i) {
+      MenuItemView* menu_item = submenu_->GetMenuItemAt(i);
+      if (menu_item->has_icon_view_)
+        icon_width = std::max(icon_width,
+            menu_item->child_at(0)->GetPreferredSize().width());
+    }
+  }
 
   if (config.always_use_icon_to_label_padding)
-    label_start_ = config.item_left_margin + config.check_width +
+    label_start_ = config.item_left_margin + icon_width +
                    config.icon_to_label_padding;
   else
     // If there are no icons don't pad by the icon to label padding. This
     // makes us look close to system menus.
-    label_start_ = config.item_left_margin + config.check_width +
-                   (has_icons ? config.icon_to_label_padding : 0);
+    label_start_ = config.item_left_margin + icon_width +
+                   (has_icons_ ? config.icon_to_label_padding : 0);
 
   if (config.render_gutter)
     label_start_ += config.gutter_width + config.gutter_to_label;
 
   MenuItemView menu_item(NULL);
   menu_item.SetTitle(ASCIIToUTF16("blah"));  // Text doesn't matter here.
   pref_menu_height_ = menu_item.GetPreferredSize().height();
 }
 
 void MenuItemView::Init(MenuItemView* parent,
@@ skipping 30 matching lines @@
   canceled_ = false;
 
   has_mnemonics_ = has_mnemonics;
   show_mnemonics_ = has_mnemonics && show_mnemonics;
 
   AddEmptyMenus();
 
   if (!MenuController::GetActiveInstance()) {
     // Only update the menu size if there are no menus showing, otherwise
     // things may shift around.
-    UpdateMenuPartSizes(has_icons_);
+    UpdateMenuPartSizes();
   }
 }
 
 int MenuItemView::GetDrawStringFlags() {
   int flags = 0;
   if (base::i18n::IsRTL())
     flags |= gfx::Canvas::TEXT_ALIGN_RIGHT;
   else
     flags |= gfx::Canvas::TEXT_ALIGN_LEFT;
 
@@ skipping 114 matching lines @@
 gfx::Size MenuItemView::GetChildPreferredSize() {
   if (!has_children())
     return gfx::Size();
 
   if (IsContainer()) {
     View* child = child_at(0);
     return child->GetPreferredSize();
   }
 
   int width = 0;
-  for (int i = 0; i < child_count(); ++i) {
+  int i = has_icon_view_ ? 1 : 0;
+  for (; i < child_count(); ++i) {
     if (i)
       width += kChildXPadding;
-    width += child_at(i)->GetPreferredSize().width();
+    gfx::Size size = child_at(i)->GetPreferredSize();
+    width += size.width();
   }
+  int height = 0;
+  if (has_icon_view_)
+    height = child_at(0)->GetPreferredSize().height();
+
   // Return a height of 0 to indicate that we should use the title height
   // instead.
-  return gfx::Size(width, 0);
+  return gfx::Size(width, height);
 }
 
 gfx::Size MenuItemView::CalculatePreferredSize() {
   gfx::Size child_size = GetChildPreferredSize();
   if (IsContainer()) {
     return gfx::Size(
         child_size.width(),
         child_size.height() + GetBottomMargin() + GetTopMargin());
   }
 
@@ skipping 21 matching lines @@
       accelerator.GetShortcutText() : string16();
 }
 
 bool MenuItemView::IsContainer() const {
   // Let the first child take over |this| when we only have one child and no
   // title.  Note that what child_count() returns is the number of children,
   // not the number of menu items.
   return child_count() == 1 && title_.empty();
 }
 
+bool MenuItemView::HasNonIconChildViews() {
+  return child_count() > (has_icon_view_ ? 1 : 0);
+}
+
 }  // namespace views