Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1193)

Unified Diff: content/common/android/command_line.cc

Issue 10532155: Upstream some more content/ DEPS-related cleanup. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/android/command_line.cc
diff --git a/content/browser/android/command_line.cc b/content/common/android/command_line.cc
similarity index 82%
rename from content/browser/android/command_line.cc
rename to content/common/android/command_line.cc
index 1883b07f0f973f10595ed99b1485b9ee93550def..4a186cc7744f8164328c8a36f94583d61e42d526 100644
--- a/content/browser/android/command_line.cc
+++ b/content/common/android/command_line.cc
@@ -2,18 +2,30 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "content/browser/android/command_line.h"
+#include "content/common/android/command_line.h"
#include "base/android/jni_string.h"
#include "base/command_line.h"
#include "base/logging.h"
#include "jni/command_line_jni.h"
-#include "content/browser/android/jni_helper.h"
using base::android::ConvertJavaStringToUTF8;
namespace {
+void ConvertJavaArrayOfStringsToVectorOfStrings(JNIEnv* env,
Yaron 2012/06/15 17:40:35 Consider moving this to base/android/jni_array.h A
no sievers 2012/06/15 20:34:41 Ah AppendJavaStringArrayToStringVector() you mean,
+ jobjectArray jstrings,
+ std::vector<std::string>* vec) {
+ vec->clear();
+ jsize length = env->GetArrayLength(jstrings);
+ for (jsize i = 0; i < length; ++i) {
+ jstring item = static_cast<jstring>(
+ env->GetObjectArrayElement(jstrings, i));
+ vec->push_back(base::android::ConvertJavaStringToUTF8(env, item));
+ env->DeleteLocalRef(item);
+ }
+}
+
void AppendJavaStringArrayToCommandLine(JNIEnv* env,
jobjectArray array,
bool includes_program) {

Powered by Google App Engine
This is Rietveld 408576698