Reimplement dynamic frame alignment for frames that are compiled via OSR or have more than 2 double…

src/ia32/lithium-codegen-ia32.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 61 matching lines @@
   status_ = GENERATING;
   CpuFeatures::Scope scope(SSE2);
 
   CodeStub::GenerateFPStubs();
 
   // Open a frame scope to indicate that there is a frame on the stack.  The
   // MANUAL indicates that the scope shouldn't actually generate code to set up
   // the frame (that is done in GeneratePrologue).
   FrameScope frame_scope(masm_, StackFrame::MANUAL);
 
+  dynamic_frame_alignment_ = chunk()->num_double_slots() > 2 ||
+                             info()->osr_ast_id() != AstNode::kNoNumber;
+
   return GeneratePrologue() &&
       GenerateBody() &&
       GenerateDeferredCode() &&
       GenerateSafepointTable();
 }
 
 
 void LCodeGen::FinishCode(Handle<Code> code) {
   ASSERT(is_done());
   code->set_stack_slots(GetStackSlotCount());
@@ skipping 54 matching lines @@
     Label ok;
     __ test(ecx, Operand(ecx));
     __ j(zero, &ok, Label::kNear);
     // +1 for return address.
     int receiver_offset = (scope()->num_parameters() + 1) * kPointerSize;
     __ mov(Operand(esp, receiver_offset),
            Immediate(isolate()->factory()->undefined_value()));
     __ bind(&ok);
   }
 
+  // Move state of dynamic frame alignment into edx.
+  __ mov(edx, Immediate(kNoAlignmentPadding));
+
+  if (dynamic_frame_alignment_) {
+     Label do_not_pad, align_loop;
+     STATIC_ASSERT(kDoubleSize == 2 * kPointerSize);
+     // Align esp to a multiple of 2 * kPointerSize.
+     __ test(esp, Immediate(kPointerSize));
+     __ j(zero, &do_not_pad, Label::kNear);
+     __ push(Immediate(0));
+     __ mov(ebx, esp);
+     __ mov(edx, Immediate(kAlignmentPaddingPushed));
+     // Copy arguments, receiver, and return address.
+     __ mov(ecx, Immediate(scope()->num_parameters() + 2));
+
+     __ bind(&align_loop);
+     __ mov(eax, Operand(ebx, 1 * kPointerSize));
+     __ mov(Operand(ebx, 0), eax);
+     __ add(Operand(ebx), Immediate(kPointerSize));
+     __ dec(ecx);
+     __ j(not_zero, &align_loop, Label::kNear);
+     __ mov(Operand(ebx, 0), Immediate(kAlignmentZapValue));
+     __ bind(&do_not_pad);
+  }
+
   __ push(ebp);  // Caller's frame pointer.
   __ mov(ebp, esp);
   __ push(esi);  // Callee's context.
   __ push(edi);  // Callee's JS function.
 
   // Reserve space for the stack slots needed by the code.
   int slots = GetStackSlotCount();
-  if (slots > 0) {
-    if (FLAG_debug_code) {
-      __ mov(Operand(eax), Immediate(slots));
-      Label loop;
-      __ bind(&loop);
-      __ push(Immediate(kSlotsZapValue));
-      __ dec(eax);
-      __ j(not_zero, &loop);
-    } else {
-      __ sub(Operand(esp), Immediate(slots * kPointerSize));
+  ASSERT_GE(slots, 1);
+  if (FLAG_debug_code) {
+    __ mov(Operand(eax), Immediate(slots));
+    Label loop;
+    __ bind(&loop);
+    __ push(Immediate(kSlotsZapValue));
+    __ dec(eax);
+    __ j(not_zero, &loop);
+  } else {
+    __ sub(Operand(esp), Immediate(slots * kPointerSize));
 #ifdef _MSC_VER
-      // On windows, you may not access the stack more than one page below
-      // the most recently mapped page. To make the allocated area randomly
-      // accessible, we write to each page in turn (the value is irrelevant).
-      const int kPageSize = 4 * KB;
-      for (int offset = slots * kPointerSize - kPageSize;
-           offset > 0;
-           offset -= kPageSize) {
-        __ mov(Operand(esp, offset), eax);
-      }
+    // On windows, you may not access the stack more than one page below
+    // the most recently mapped page. To make the allocated area randomly
+    // accessible, we write to each page in turn (the value is irrelevant).
+    const int kPageSize = 4 * KB;
+    for (int offset = slots * kPointerSize - kPageSize;
+         offset > 0;
+         offset -= kPageSize) {
+      __ mov(Operand(esp, offset), eax);
+    }
 #endif
-    }
   }
 
+  // Store dynamic frame alignment state in the first local.
+  __ mov(Operand(ebp, JavaScriptFrameConstants::kLocal0Offset), edx);

[danno, 2012/06/11 10:53:14]

To reduce the theoretical expense of the tag in the non-dynamic_frame_alignment_
case, can you do the immediate store in a single instruction?

+
   // Possibly allocate a local context.
   int heap_slots = scope()->num_heap_slots() - Context::MIN_CONTEXT_SLOTS;
   if (heap_slots > 0) {
     Comment(";;; Allocate local context");
     // Argument to NewContext is the function, which is still in edi.
     __ push(edi);
     if (heap_slots <= FastNewContextStub::kMaximumSlots) {
       FastNewContextStub stub(heap_slots);
       __ CallStub(&stub);
     } else {
@@ skipping 1894 matching lines @@
 void LCodeGen::DoReturn(LReturn* instr) {
   if (FLAG_trace) {
     // Preserve the return value on the stack and rely on the runtime call
     // to return the value in the same register.  We're leaving the code
     // managed by the register allocator and tearing down the frame, it's
     // safe to write to the context register.
     __ push(eax);
     __ mov(esi, Operand(ebp, StandardFrameConstants::kContextOffset));
     __ CallRuntime(Runtime::kTraceExit, 1);
   }
+  if (dynamic_frame_alignment_) {
+    // Fetch the state of the dynamic frame alignment.
+    __ mov(edx, Operand(ebp, JavaScriptFrameConstants::kLocal0Offset));

[danno, 2012/06/11 10:53:14]

Can you alias something like kFrameAlignmentCookieOffset to kLocalOffset and use
it instead?

+  }
   __ mov(esp, ebp);
   __ pop(ebp);
+  if (dynamic_frame_alignment_) {
+    Label no_padding;
+    __ cmp(edx, Immediate(kNoAlignmentPadding));
+    __ j(equal, &no_padding);
+    if (FLAG_debug_code) {
+      __ cmp(Operand(esp, (GetParameterCount() + 2) * kPointerSize),
+             Immediate(kAlignmentZapValue));
+      __ Assert(equal, "expected alignment marker");
+    }
+    __ Ret((GetParameterCount() + 2) * kPointerSize, ecx);
+    __ bind(&no_padding);
+  }
   __ Ret((GetParameterCount() + 1) * kPointerSize, ecx);
 }
 
 
 void LCodeGen::DoLoadGlobalCell(LLoadGlobalCell* instr) {
   Register result = ToRegister(instr->result());
   __ mov(result, Operand::Cell(instr->hydrogen()->cell()));
   if (instr->hydrogen()->RequiresHoleCheck()) {
     __ cmp(result, factory()->the_hole_value());
     DeoptimizeIf(equal, instr->environment());
@@ skipping 2991 matching lines @@
                               FixedArray::kHeaderSize - kPointerSize));
   __ bind(&done);
 }
 
 
 #undef __
 
 } }  // namespace v8::internal
 
 #endif  // V8_TARGET_ARCH_IA32