src/hydrogen.cc - Issue 10532063: Optimistically assume that elements IC only transition once.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen.cc

Issue 10532063: Optimistically assume that elements IC only transition once. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Add assertion Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/hydrogen.cc

diff --git a/src/hydrogen.cc b/src/hydrogen.cc

index e2fbfb59c4b6fbf3462ba1343b7e8fcb1354997e..005cbe019e4adf15e1cd3de5b3a5d844e238b46b 100644

--- a/src/hydrogen.cc

+++ b/src/hydrogen.cc

@@ -5563,7 +5563,7 @@ HValue* HGraphBuilder::HandlePolymorphicElementAccess(HValue* object,

AddInstruction(transition);

} else {

type_todo[map->elements_kind()] = true;

- if (map->elements_kind() >= FIRST_EXTERNAL_ARRAY_ELEMENTS_KIND) {

+ if (IsExternalArrayElementsKind(map->elements_kind())) {

todo_external_array = true;

}

num_untransitionable_maps++;

« no previous file with comments | « src/elements-kind.h ('k') | src/ic.h » ('j') | test/mjsunit/elements-transition-hoisting.js » ('J')