Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1100)

Unified Diff: chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc

Issue 10532048: [cros] Initial WebRTC-enabled implementation of user image picker on OOBE. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Cleanup and addressed comments Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc
diff --git a/chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc b/chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc
index f7f4fc06b5a7ee3d4308601eee97d0bd17f81120..4fd023540ab3700f770c7311ee48ab68f42fbaf1 100644
--- a/chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc
+++ b/chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc
@@ -6,6 +6,7 @@
#include "base/bind.h"
#include "base/bind_helpers.h"
+#include "base/command_line.h"
#include "base/logging.h"
#include "base/metrics/histogram.h"
#include "base/values.h"
@@ -15,6 +16,7 @@
#include "chrome/browser/chromeos/login/webui_login_display.h"
#include "chrome/browser/chromeos/options/take_photo_dialog.h"
#include "chrome/browser/ui/webui/web_ui_util.h"
+#include "chrome/common/chrome_switches.h"
#include "chrome/common/url_constants.h"
#include "grit/generated_resources.h"
#include "ui/base/l10n/l10n_util.h"
@@ -60,6 +62,10 @@ void UserImageScreenHandler::GetLocalizedStrings(
l10n_util::GetStringUTF16(IDS_IMAGE_SCREEN_PROFILE_LOADING_PHOTO));
localized_strings->SetString("okButtonText",
l10n_util::GetStringUTF16(IDS_OK));
+ if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kEnableHtml5Camera))
+ localized_strings->SetString("cameraType", "webrtc");
+ else
+ localized_strings->SetString("cameraType", "old");
}
void UserImageScreenHandler::Initialize() {
@@ -127,6 +133,9 @@ void UserImageScreenHandler::ShowCameraInitializing() {
}
void UserImageScreenHandler::CheckCameraPresence() {
+ // For WebRTC, camera presence checked is done on JS side.
+ if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kEnableHtml5Camera))
+ return;
CameraDetector::StartPresenceCheck(
base::Bind(&UserImageScreenHandler::OnCameraPresenceCheckDone,
weak_factory_.GetWeakPtr()));
@@ -140,6 +149,9 @@ void UserImageScreenHandler::RegisterMessages() {
web_ui()->RegisterMessageCallback("takePhoto",
base::Bind(&UserImageScreenHandler::HandleTakePhoto,
base::Unretained(this)));
+ web_ui()->RegisterMessageCallback("photoTaken",
+ base::Bind(&UserImageScreenHandler::HandlePhotoTaken,
+ base::Unretained(this)));
web_ui()->RegisterMessageCallback("selectImage",
base::Bind(&UserImageScreenHandler::HandleSelectImage,
base::Unretained(this)));
@@ -182,6 +194,15 @@ void UserImageScreenHandler::OnPhotoAccepted(const gfx::ImageSkia& photo) {
data_url);
}
+void UserImageScreenHandler::HandlePhotoTaken(const base::ListValue* args) {
+ std::string image_url;
+ if (!args || args->GetSize() != 1 || !args->GetString(0, &image_url))
+ NOTREACHED();
+ DCHECK(!image_url.empty());
+ user_photo_data_url_ = image_url;
+ user_photo_ = web_ui_util::GetImageFromDataUrl(image_url);
+}
+
void UserImageScreenHandler::HandleTakePhoto(const base::ListValue* args) {
DCHECK(args && args->empty());
views::Widget* window = views::Widget::CreateWindowWithParent(
@@ -192,12 +213,8 @@ void UserImageScreenHandler::HandleTakePhoto(const base::ListValue* args) {
void UserImageScreenHandler::HandleSelectImage(const base::ListValue* args) {
std::string image_url;
- if (!args ||
- args->GetSize() != 1 ||
- !args->GetString(0, &image_url)) {
+ if (!args || args->GetSize() != 1 || !args->GetString(0, &image_url))
NOTREACHED();
- return;
- }
if (image_url.empty())
return;

Powered by Google App Engine
This is Rietveld 408576698