Make imageSkia:::extractSubset multi-image aware.

ui/gfx/image/image_skia.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/gfx/image/image_skia.h"
 
 #include <limits>
 #include <cmath>
 
 #include "base/logging.h"
 #include "ui/gfx/size.h"
+#include "ui/gfx/skia_util.h"
 
 namespace gfx {
 
 namespace internal {
 
 // A helper class such that ImageSkia can be cheaply copied. ImageSkia holds a
 // refptr instance of ImageSkiaStorage, which in turn holds all of ImageSkia's
 // information.
 class ImageSkiaStorage : public base::RefCounted<ImageSkiaStorage> {
  public:
@@ skipping 130 matching lines @@
   return isNull() ? 0 : storage_->size().width();
 }
 
 int ImageSkia::height() const {
   return isNull() ? 0 : storage_->size().height();
 }
 
 bool ImageSkia::extractSubset(ImageSkia* dst, const SkIRect& subset) const {
   if (isNull())
     return false;
-  SkBitmap dst_bitmap;
-  bool return_value  = storage_->bitmaps()[0].extractSubset(&dst_bitmap,
-                                                            subset);
-  *dst = ImageSkia(dst_bitmap);
-  return return_value;
+  gfx::ImageSkia image;
+  int dip_width = width();
+  std::vector<SkBitmap> bitmaps = storage_->bitmaps();

[sky, 2012/06/07 17:42:19]

const std::vector<SkBitmap>&

[kevers, 2012/06/07 18:12:00]

Done.

+  for (std::vector<SkBitmap>::const_iterator it = bitmaps.begin();
+       it != bitmaps.end(); ++it) {
+    SkBitmap bitmap = *it;

[sky, 2012/06/07 17:42:19]

const SkBitmap&

[kevers, 2012/06/07 18:12:00]

Done.

+    int px_width = it->width();
+    float dip_scale = static_cast<float>(px_width) /
+        static_cast<float>(dip_width);
+    int x = static_cast<int>(subset.left() * dip_scale + 0.5);

[sky, 2012/06/07 17:42:19]

Add a comment as to why the + .5

[kevers, 2012/06/07 18:12:00]

Done.

+    int y = static_cast<int>(subset.top() * dip_scale + 0.5);
+    int w = static_cast<int>(subset.width() * dip_scale + 0.5);
+    int h = static_cast<int>(subset.height() * dip_scale + 0.5);
+    SkBitmap dst_bitmap;
+    SkIRect scaled_subset = SkIRect::MakeXYWH(x, y, w, h);
+    if (bitmap.extractSubset(&dst_bitmap, scaled_subset))
+      image.AddBitmapForScale(dst_bitmap, dip_scale);
+  }
+  if (image.empty())
+    return false;
+
+  *dst = image;
+  return true;
 }
 
 const std::vector<SkBitmap> ImageSkia::bitmaps() const {
   return storage_->bitmaps();
 }
 
 const SkBitmap* ImageSkia::bitmap() const {
   if (isNull()) {
     // Callers expect an SkBitmap even if it is |isNull()|.
     // TODO(pkotwicz): Fix this.
@@ skipping 46 matching lines @@
 
   if (closest_index >= 0) {
     *bitmap_scale_factor = static_cast<float>(bitmaps[closest_index].width()) /
         width();
   }
 
   return closest_index;
 }
 
 }  // namespace gfx