Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1252)

Unified Diff: sync/sessions/sync_session.cc

Issue 10523003: Refactor following sync commit loop change (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Minor fixes Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/sessions/sync_session.cc
diff --git a/sync/sessions/sync_session.cc b/sync/sessions/sync_session.cc
index 85ac8ccd7b72b6785191bc3915ae544f96420bd4..254bea58a86dd50622ca7b62116f8184101ee783 100644
--- a/sync/sessions/sync_session.cc
+++ b/sync/sessions/sync_session.cc
@@ -234,13 +234,9 @@ bool IsError(SyncerError error) {
bool SyncSession::Succeeded() const {
const bool download_updates_error =
IsError(status_controller_->error().last_download_updates_result);
- const bool post_commit_error =
- IsError(status_controller_->error().last_post_commit_result);
- const bool process_commit_response_error =
- IsError(status_controller_->error().last_process_commit_response_result);
- return !download_updates_error
- && !post_commit_error
- && !process_commit_response_error;
+ const bool commit_error =
+ IsError(status_controller_->error().commit_result);
+ return !download_updates_error && !commit_error;
}
} // namespace sessions

Powered by Google App Engine
This is Rietveld 408576698