Issue 10521005: A little more cleanup of DEPS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10521005: A little more cleanup of DEPS. (Closed)

Created:
8 years, 6 months ago by jam

Modified:
8 years, 6 months ago

Reviewers:
Avi (use Gerrit)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch-content_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

A little more cleanup of DEPS. BUG=98716 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=140304

Patch Set 1 #

Total comments: 2

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -8 lines)			Patch
M	chrome/DEPS	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/test/DEPS	View	1 chunk	+2 lines, -2 lines	2 comments	Download
M	content/DEPS	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	content/renderer/DEPS	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Avi (use Gerrit)

lgtm http://codereview.chromium.org/10521005/diff/1/chrome/test/DEPS File chrome/test/DEPS (right): http://codereview.chromium.org/10521005/diff/1/chrome/test/DEPS#newcode13 chrome/test/DEPS:13: # http://crbug.com/98716. I don't like putting periods like ...

8 years, 6 months ago (2012-06-04 16:39:12 UTC) #2

jam

8 years, 6 months ago (2012-06-04 16:43:29 UTC) #3

http://codereview.chromium.org/10521005/diff/1/chrome/test/DEPS
File chrome/test/DEPS (right):

http://codereview.chromium.org/10521005/diff/1/chrome/test/DEPS#newcode13
chrome/test/DEPS:13: # http://crbug.com/98716.
On 2012/06/04 16:39:12, Avi wrote:
> I don't like putting periods like that; Xcode linkifies the period too. Can
you
> put a space there?

ah, didn't know that about xcode, thanks. just took it out

Expand Messages | Collapse Messages