Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2412)

Unified Diff: chrome/common/extensions/value_counter_unittest.cc

Issue 10514013: Filtered events. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix 80 char Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/value_counter_unittest.cc
diff --git a/chrome/common/extensions/value_counter_unittest.cc b/chrome/common/extensions/value_counter_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..f8c43130ef0bc5127f2fb0a55281cd91f9102dff
--- /dev/null
+++ b/chrome/common/extensions/value_counter_unittest.cc
@@ -0,0 +1,42 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/memory/scoped_ptr.h"
+#include "base/values.h"
+#include "chrome/common/extensions/value_counter.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+class ValueCounterUnittest : public testing::Test {
+};
+
+TEST_F(ValueCounterUnittest, TestAddingSameValue) {
+ extensions::ValueCounter vc;
+ scoped_ptr<base::Value> value(new ListValue());
battre 2012/06/20 09:50:46 nit: you can allocate this and the other value* va
koz (OOO until 15th September) 2012/06/21 02:23:11 Done.
+ ASSERT_EQ(1, vc.Add(*value));
+ ASSERT_EQ(2, vc.Add(*value));
+}
+
+TEST_F(ValueCounterUnittest, TestAddingDifferentValue) {
+ extensions::ValueCounter vc;
+ scoped_ptr<base::Value> value1(new ListValue());
+ scoped_ptr<base::Value> value2(new DictionaryValue());
+ ASSERT_EQ(1, vc.Add(*value1));
+ ASSERT_EQ(1, vc.Add(*value2));
+}
+
+TEST_F(ValueCounterUnittest, TestRemovingValue) {
+ extensions::ValueCounter vc;
+ scoped_ptr<base::Value> value(new ListValue());
+ ASSERT_EQ(1, vc.Add(*value));
+ ASSERT_EQ(2, vc.Add(*value));
+ ASSERT_EQ(1, vc.Remove(*value));
+ ASSERT_EQ(0, vc.Remove(*value));
+}
+
+TEST_F(ValueCounterUnittest, TestAddIfMissing) {
+ extensions::ValueCounter vc;
+ scoped_ptr<base::Value> value(new ListValue());
+ ASSERT_EQ(1, vc.AddIfMissing(*value));
+ ASSERT_EQ(1, vc.AddIfMissing(*value));
+}

Powered by Google App Engine
This is Rietveld 408576698