Filtered events.

chrome/browser/extensions/extension_prefs.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_prefs.h"
 
 #include "base/string_number_conversions.h"
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/extensions/admin_policy.h"
@@ skipping 155 matching lines @@
 // A preference that contains extension-set content settings.
 const char kPrefContentSettings[] = "content_settings";
 
 // A preference that contains extension-set content settings.
 const char kPrefIncognitoContentSettings[] = "incognito_content_settings";
 
 // A list of event names that this extension has registered from its lazy
 // background page.
 const char kRegisteredEvents[] = "events";
 
+// A dictionary of event names to lists of filters that this extension has
+// registered from its lazy background page.
+const char kFilteredEvents[] = "filtered_events";
+
 // Persisted value for omnibox.setDefaultSuggestion.
 const char kOmniboxDefaultSuggestion[] = "omnibox_default_suggestion";
 
 // Provider of write access to a dictionary storing extension prefs.
 class ScopedExtensionPrefUpdate : public DictionaryPrefUpdate {
  public:
   ScopedExtensionPrefUpdate(PrefService* service,
                             const std::string& extension_id) :
     DictionaryPrefUpdate(service, ExtensionPrefs::kExtensionsPref),
     extension_id_(extension_id) {}
@@ skipping 764 matching lines @@
     return events;
 
   for (size_t i = 0; i < value->GetSize(); ++i) {
     std::string event;
     if (value->GetString(i, &event))
       events.insert(event);
   }
   return events;
 }
 
+void ExtensionPrefs::AddFilterToEvent(const std::string& event_name,
+                                      const std::string& extension_id,
+                                      const DictionaryValue* filter) {
+  const DictionaryValue* filtered_events = GetFilteredEvents(extension_id);
+  scoped_ptr<DictionaryValue> new_filtered_events;
+  if (!filtered_events)
+    new_filtered_events.reset(new DictionaryValue);
+  else
+    new_filtered_events.reset(filtered_events->DeepCopy());
+
+  ListValue* filter_list = NULL;
+  if (!new_filtered_events->GetList(event_name, &filter_list)) {
+    filter_list = new ListValue();
+    new_filtered_events->Set(event_name, filter_list);
+  }
+  filter_list->Append(filter->DeepCopy());
+
+  UpdateExtensionPref(extension_id, kFilteredEvents,
+                      new_filtered_events.release());

[battre, 2012/06/19 14:26:23]

What do you think of modifying the list instead of creating a deep copy? Same in
RemoveFilterFromEvent. You can use a ScopedExtensionPrefUpdate.

[koz (OOO until 15th September), 2012/06/20 08:05:56]

Sounds good! Done.

+}
+
+void ExtensionPrefs::RemoveFilterFromEvent(const std::string& event_name,
+                                           const std::string& extension_id,
+                                           const DictionaryValue* filter) {
+  const DictionaryValue* filtered_events = GetFilteredEvents(extension_id);
+  if (!filtered_events)
+    return;
+
+  scoped_ptr<DictionaryValue> new_filtered_events(filtered_events->DeepCopy());
+  ListValue* filter_list;
+  if (!new_filtered_events->GetList(event_name, &filter_list))
+    return;
+
+  bool removed = false;
+  for (size_t i = 0; i < filter_list->GetSize(); i++) {
+    DictionaryValue* filter;
+    CHECK(filter_list->GetDictionary(i, &filter));
+    if (filter->Equals(filter)) {
+      filter_list->Remove(i, NULL);
+      removed = true;
+      break;
+    }
+  }
+
+  if (removed)
+    UpdateExtensionPref(extension_id, kFilteredEvents,
+                        new_filtered_events.release());
+}
+
+const DictionaryValue* ExtensionPrefs::GetFilteredEvents(
+    const std::string& extension_id) {
+  const DictionaryValue* extension = GetExtensionPref(extension_id);
+  if (!extension)
+    return NULL;
+  DictionaryValue* result = NULL;
+  if (!extension->GetDictionary(kFilteredEvents, &result))
+    return NULL;
+  return result;
+}
+
 void ExtensionPrefs::SetRegisteredEvents(
     const std::string& extension_id, const std::set<std::string>& events) {
   ListValue* value = new ListValue();
   for (std::set<std::string>::const_iterator it = events.begin();
        it != events.end(); ++it) {
     value->Append(new StringValue(*it));
   }
   UpdateExtensionPref(extension_id, kRegisteredEvents, value);
 }
 
@@ skipping 909 matching lines @@
                             PrefService::UNSYNCABLE_PREF);
   prefs->RegisterInt64Pref(prefs::kLastExtensionsUpdateCheck,
                            0,  // default value
                            PrefService::UNSYNCABLE_PREF);
   prefs->RegisterInt64Pref(prefs::kNextExtensionsUpdateCheck,
                            0,  // default value
                            PrefService::UNSYNCABLE_PREF);
   prefs->RegisterListPref(prefs::kExtensionAllowedInstallSites,
                           PrefService::UNSYNCABLE_PREF);
 }