lib/dom/scripts/databasebuilder.py - Issue 10513004: Implement v8-like overload resolving.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/dom/scripts/databasebuilder.py

Issue 10513004: Implement v8-like overload resolving. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/dom/scripts/databasebuilder.py

diff --git a/lib/dom/scripts/databasebuilder.py b/lib/dom/scripts/databasebuilder.py

index de4c7548708e0cb62717c0b26895009c34684e0a..68e678fb3f193a297e6be2b52135f9532241ef0a 100755

--- a/lib/dom/scripts/databasebuilder.py

+++ b/lib/dom/scripts/databasebuilder.py

@@ -126,9 +126,8 @@ class DatabaseBuilder(object):

for i in range(0, len(op.arguments)):

argument = op.arguments[i]

in_optional_whitelist = (interface.id, op.id, argument.id) in optional_argument_whitelist

- if in_optional_whitelist or set(['Optional', 'Callback']).issubset(argument.ext_attrs.keys()):

+ if in_optional_whitelist:

argument.ext_attrs['Optional'] = None

- argument.ext_attrs['RequiredCppParameter'] = None

def _rename_types(self, idl_file, import_options):

"""Rename interface and type names with names provided in the