dbus/string_util.h - Issue 10502011: Explicitly CHECK arguments in dbus::MessageWriter::AppendString/ObjectPath

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: dbus/string_util.h

Issue 10502011: Explicitly CHECK arguments in dbus::MessageWriter::AppendString/ObjectPath (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix wording Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef DBUS_STRING_UTIL_H_

	6 #define DBUS_STRING_UTIL_H_

	7 #pragma once

	8

	9 #include <string>

	10

	11 namespace dbus {

	12

	13 // Returns true if the specified string is a valid object path.

	14 bool IsStringValidObjectPath(const std::string& string);
	satorux1 2012/06/04 23:29:19 IsValidObjectPath() should suffice. string -> val IsValidObjectPath() should suffice. string -> value? hashimoto 2012/06/05 01:50:29 Done. Show quoted text On 2012/06/04 23:29:19, satorux1 wrote: > IsValidObjectPath() should suffice. > > string -> value? Done.
	15

	16 } // namespace dbus

	17

	18 #endif // DBUS_STRING_UTIL_H_

OLD	NEW

« no previous file with comments | « dbus/object_path.cc ('k') | dbus/string_util.cc » ('j') | dbus/string_util.cc » ('J')