Issue 1050007: Update sbt to match hardcoded logic in mod_image_for_test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1050007: Update sbt to match hardcoded logic in mod_image_for_test (Closed)

Created:
10 years, 9 months ago by kmixter1

Modified:
9 years, 7 months ago

Reviewers:
rochberg

CC:
chromium-os-reviews_chromium.org

Visibility:
Public.

Description

Update sbt to match hardcoded logic in mod_image_for_test

Patch Set 1 #

Total comments: 1

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -4 lines)			Patch
	M	src/scripts/sync_build_test.sh	View		1 chunk	+1 line, -4 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

rochberg

10 years, 9 months ago (2010-03-18 15:24:08 UTC) #2

LGTM
Thanks

http://codereview.chromium.org/1050007/diff/1/2
File src/scripts/sync_build_test.sh (right):

http://codereview.chromium.org/1050007/diff/1/2#newcode183
src/scripts/sync_build_test.sh:183: FLAGS_chronos_passwd="test0000"
Think about warning here?

Expand Messages | Collapse Messages