Die build.py, Die: Part 2 (LocalFetcher, Handlebar support, build script)

chrome/common/extensions/docs/server2/resource_fetcher.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
+import logging
+import os
+
 SUBVERSION_URL = 'http://src.chromium.org/viewvc/chrome/'
 TRUNK_URL = SUBVERSION_URL + 'trunk/'
 BRANCH_URL = SUBVERSION_URL + 'branches/'
 
 class SubversionFetcher(object):
-  """Class to fetch code from src.chromium.org.
+  """Class to fetch docs from src.chromium.org.

[Aaron Boodman, 2012/06/02 07:50:22]

It will fetch lots of things. How about s/docs/resources/

[cduvall, 2012/06/02 19:12:05]

Done.

   """
   def __init__(self, urlfetch):
     self.urlfetch = urlfetch
 
   def _GetURLFromBranch(self, branch):
     if branch == 'trunk':
       return TRUNK_URL
     return BRANCH_URL + branch + '/'
 
   def FetchResource(self, branch, path):
     url = self._GetURLFromBranch(branch) + path
     result = self.urlfetch.fetch(url)
     return result
+
+class LocalFetcher(object):

[Aaron Boodman, 2012/06/02 07:50:22]

Each class should typically be in a separate file with the same name, even if
they are small. Sorry I didn't notice this last time.

[cduvall, 2012/06/02 19:12:05]

Done.

+  """Class to fetch docs from local filesystem.
+  """
+  class _Resource(object):
+    def __init__(self):

[Aaron Boodman, 2012/06/02 07:50:22]

It seems like it would be more robust to pass in a base path to fetch from.

[cduvall, 2012/06/02 19:12:05]

Done.

+      self.content = ''
+      self.headers = {}
+
+  def _ReadFile(self, filename):
+    with open(filename, 'r') as f:
+      return f.read()
+
+  def FetchResource(self, branch, path):
+    result = self._Resource()
+    logging.info('Reading: ' + path)
+    result.content = self._ReadFile(path)
+    return result