Die build.py, Die: Part 2 (LocalFetcher, Handlebar support, build script)

chrome/common/extensions/docs/server2/build_server.py

+#!/usr/bin/env python
+# Copyright (c) 2012 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+import shutil
+import sys
+
+THIRD_PARTY_DIR = sys.path[0] + '/../../../../../third_party/'

[Aaron Boodman, 2012/06/02 07:50:22]

Not sure if this will work on Windows. Use os.join() to get the right separators
automatically.

[cduvall, 2012/06/02 19:12:05]

Done.

+LOCAL_THIRD_PARTY_DIR = sys.path[0] + '/third_party/'

[Aaron Boodman, 2012/06/02 07:50:22]

For added safety, do a sanity check that third_party is there. If not, warn that
probably not running from correct directory.

[cduvall, 2012/06/02 19:12:05]

sys.path[0] allows this to work when run from any directory, but I'll add the
check anyway for safety. I'm just checking the third_party dir under src/
because the local one is created every run.

[Aaron Boodman, 2012/06/03 05:43:14]

Ah, my mistake. I guess the check is not necessary then. My only goal is that it
either works from any directory, or tells you when run from wrong directory (in
which case it should tell you which directory it would like to be run from).

+
+def main():
+  shutil.rmtree(LOCAL_THIRD_PARTY_DIR, True)
+  shutil.copytree(THIRD_PARTY_DIR + 'handlebar',
+      LOCAL_THIRD_PARTY_DIR + 'handlebar')
+  with open(LOCAL_THIRD_PARTY_DIR + '__init__.py', 'w') as f:
+    f.write('\n')

[Aaron Boodman, 2012/06/02 07:50:22]

You can just do os.utime(path).

[cduvall, 2012/06/02 19:12:05]

Done.

+  shutil.copy(LOCAL_THIRD_PARTY_DIR + '__init__.py',
+      LOCAL_THIRD_PARTY_DIR + 'handlebar')
+  with open(LOCAL_THIRD_PARTY_DIR + 'handlebar/__init__.py', 'a') as f:
+    f.write('\nfrom handlebar import Handlebar\n')

[Aaron Boodman, 2012/06/02 07:50:22]

I think it would be less surprising to just import this in the files it is used.

[cduvall, 2012/06/02 19:12:05]

This import is needed to access the class (I think because Handlebar is not in
the same directory as the rest of the files). In the other files, there is still
a 'from third_party.handlebar import Handlebar', so it shouldn't be too
confusing. It can't find the name Handlebar without this import in __init__.py.

+
+if __name__ == '__main__':
+  main()