Issue 10497013: Move render_view_test.h header from content\test to content\public\test. This way we can enforce th…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10497013: Move render_view_test.h header from content\test to content\public\test. This way we can enforce th… (Closed)

Created:
8 years, 6 months ago by jam

Modified:
8 years, 6 months ago

Reviewers:
Avi (use Gerrit)

CC:
chromium-reviews, sadrul, jochen+watch-content_chromium.org, ben+watch_chromium.org, jam, joi+watch-content_chromium.org, marja+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Move render_view_test.h header from content\test to content\public\test. This way we can enforce that internal content headers don't leak to embedders. I moved the SendKeyEvent from RenderViewTest to RenderViewImplTest, which was the only class it was used in. This way we don't have to expose mock_keyboard.h as well. BUG=98716 TBR=phajdan.jr Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=140255

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+237 lines, -362 lines)			Patch
M	chrome/browser/notifications/desktop_notifications_unittest.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/notifications/desktop_notifications_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sessions/tab_restore_service_browsertest.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/translate/translate_manager_browsertest.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/ash/window_positioner_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/window_sizer_ash_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/renderer/automation/automation_renderer_helper_browsertest.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/test/base/chrome_render_view_test.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/content_tests.gypi	View		2 chunks	+1 line, -1 line	0 comments	Download
A +	content/public/test/render_view_test.h	View	1 2	6 chunks	+16 lines, -23 lines	0 comments	Download
M	content/renderer/external_popup_menu_browsertest.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/mouse_lock_dispatcher_browsertest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/render_view_browsertest.cc	View	1 2	2 chunks	+179 lines, -1 line	0 comments	Download
M	content/renderer/render_view_browsertest_mac.mm	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
D	content/test/render_view_test.h	View		1 chunk	+0 lines, -152 lines	0 comments	Download
M	content/test/render_view_test.cc	View	1 2	8 chunks	+27 lines, -172 lines	0 comments	Download
M	content/test/render_widget_browsertest.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages

Issue 10497013: Move render_view_test.h header from content\test to content\public\test. This way we can enforce th… (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : fix checkdeps by moving SendKeyEvent #

Patch Set 4 : fix mac #

Messages