Issue 10494013: Add flag which shows missing 2x resources

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10494013: Add flag which shows missing 2x resources (Closed)

Created:
8 years, 6 months ago by pkotwicz

Modified:
8 years, 6 months ago

Reviewers:
sky

CC:
chromium-reviews, sadrul, ben+watch_chromium.org, oshima

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add flag which shows visually places where hidpi resources are supported however a hidpi resource cannot be shown because of missing assets Bug=131631 Test=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141222

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -0 lines)			Patch
M	ui/base/resource/resource_bundle.cc	View	1 2	4 chunks	+38 lines, -0 lines	0 comments	Download
M	ui/base/ui_base_switches.h	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/base/ui_base_switches.cc	View	1 2 3	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM http://codereview.chromium.org/10494013/diff/2001/ui/base/resource/resource_bundle.cc File ui/base/resource/resource_bundle.cc (right): http://codereview.chromium.org/10494013/diff/2001/ui/base/resource/resource_bundle.cc#newcode57 ui/base/resource/resource_bundle.cc:57: float bitmap_scale; Why don't you also log. http://codereview.chromium.org/10494013/diff/2001/ui/base/ui_base_switches.h ...

8 years, 6 months ago (2012-06-08 03:01:21 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10494013/2004

8 years, 6 months ago (2012-06-08 15:28:35 UTC) #3

Change committed as 141222

Expand Messages | Collapse Messages