Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: chrome/browser/ui/gtk/zoom_bubble_gtk.cc

Issue 10494004: Implements a zoom icon in the Omnibox for Views. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/gtk/zoom_bubble_gtk.cc
diff --git a/chrome/browser/ui/gtk/zoom_bubble_gtk.cc b/chrome/browser/ui/gtk/zoom_bubble_gtk.cc
index 3037f12741bee51ddee3ee8b3373e5e1de39e837..e7dea872227656970f755622fefce2268eb21c30 100644
--- a/chrome/browser/ui/gtk/zoom_bubble_gtk.cc
+++ b/chrome/browser/ui/gtk/zoom_bubble_gtk.cc
@@ -33,13 +33,11 @@ const int kBubbleAnchorHeight = 25;
}
// static
-void ZoomBubbleGtk::Show(GtkWidget* anchor,
- Profile* profile,
- int zoom_percent,
- bool autoclose) {
+void ZoomBubbleGtk::Show(GtkWidget* anchor, Profile* profile,
+ int zoomPercent, bool autoclose) {
Ben Goodger (Google) 2012/06/04 15:16:49 leave
Kyle Horimoto 2012/06/05 05:03:59 This was changed in my other CL and must have gott
if (g_bubble)
ZoomBubbleGtk::Close();
- g_bubble = new ZoomBubbleGtk(anchor, profile, zoom_percent, autoclose);
+ g_bubble = new ZoomBubbleGtk(anchor, profile, zoomPercent, autoclose);
Ben Goodger (Google) 2012/06/04 15:16:49 leave this parameter name the way it was
Kyle Horimoto 2012/06/05 05:03:59 Same.
}
// static
@@ -64,12 +62,12 @@ void ZoomBubbleGtk::Observe(int type,
ZoomBubbleGtk::ZoomBubbleGtk(GtkWidget* anchor,
Profile* profile,
- int zoom_percent,
+ int zoomPercent,
bool autoclose)
: theme_service_(GtkThemeService::GetFrom(profile)),
factory_(this) {
string16 labelText = l10n_util::GetStringFUTF16Int(
- IDS_ZOOM_PERCENT, zoom_percent);
+ IDS_ZOOM_PERCENT, zoomPercent);
label_ = gtk_label_new(UTF16ToUTF8(labelText).c_str());
GtkWidget* alignment = gtk_alignment_new(0, 0, 1, 1);

Powered by Google App Engine
This is Rietveld 408576698