Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: chrome/chrome_tests.gypi

Issue 10492009: Move test headers from content\test to content\public\test. This way we can enforce that internal c… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: fix mac Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/chrome_tests.gypi
===================================================================
--- chrome/chrome_tests.gypi (revision 140250)
+++ chrome/chrome_tests.gypi (working copy)
@@ -3018,6 +3018,7 @@
'../content/browser/speech/speech_recognition_browsertest.cc',
'../content/browser/webkit_browsertest.cc',
'../content/browser/worker_host/test/worker_browsertest.cc',
+ '../content/public/test/render_widget_browsertest.h',
Paweł Hajdan Jr. 2012/06/05 09:47:24 nit: Wasn't the convention to have public header f
jam 2012/06/05 15:57:54 I think these files need to be here since we only
'../content/renderer/mouse_lock_dispatcher_browsertest.cc',
'../content/renderer/render_view_browsertest.cc',
'../content/renderer/render_view_browsertest_mac.mm',
@@ -3026,7 +3027,6 @@
'../content/test/layout_browsertest.cc',
'../content/test/layout_browsertest.h',
'../content/test/render_widget_browsertest.cc',
- '../content/test/render_widget_browsertest.h',
'../content/test/test_launcher.cc',
'../content/test/test_launcher.h',
],

Powered by Google App Engine
This is Rietveld 408576698