Use a #fefefe solid color wallpaper background before user login for GAIA login flow

chrome/browser/chromeos/login/user_manager_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/user_manager_impl.h"
 
 #include <vector>
 
 #include "ash/shell.h"
 #include "ash/desktop_background/desktop_background_controller.h"
@@ skipping 340 matching lines @@
   NotifyOnLogin();
 }
 
 void UserManagerImpl::StubUserLoggedIn() {
   is_current_user_ephemeral_ = true;
   logged_in_user_ = new User(kStubUser, false);
   logged_in_user_->SetImage(GetDefaultImage(kStubDefaultImageIndex),
                             kStubDefaultImageIndex);
 }
 
-void UserManagerImpl::SetLoggedInUserWallpaper() {
+void UserManagerImpl::InitializeWallpaper() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
   if (!IsUserLoggedIn() || IsLoggedInAsStub()) {

[Nikita (slow), 2012/06/07 09:40:28]

https://chromiumcodereview.appspot.com/10541007/ has landed.
It preselects last logged in user on boot from sign in screen that triggers
wallpaper load. That means that you don't to set empty wallpaper in case
!IsUserLoggedIn()

[bshe, 2012/06/08 15:06:30]

right. And only for GAIA login flow, we need to set the solid color background.

     ash::Shell::GetInstance()->desktop_background_controller()->
         SetDefaultWallpaper(ash::GetInvalidWallpaperIndex());
     return;
   }
   UserSelected(GetLoggedInUser().email());
 }
 
 void UserManagerImpl::UserSelected(const std::string& email) {
   if (IsKnownUser(email)) {
     User::WallpaperType type;
@@ skipping 586 matching lines @@
           DictionaryPrefUpdate prefs_wallpapers_update(local_state,
                                                        kUserWallpapers);
           prefs_wallpapers_update->RemoveWithoutPathExpansion(username, NULL);
           SaveUserWallpaperProperties(username, User::DEFAULT, index);
         }
       }
     }
   }
 }
 
 void UserManagerImpl::GetLoggedInUserWallpaperProperties(

[Nikita (slow), 2012/06/06 11:27:46]

This method is called from:

1. UserManagerImpl::EnsureLoggedInUserWallpaperLoaded() on sign in.
2. SetWallpaperOptionsHandler::HandlePageShown()

     User::WallpaperType* type,
     int* index) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
   if (!IsUserLoggedIn() || IsLoggedInAsStub()) {
     *type = current_user_wallpaper_type_ = User::DEFAULT;
     *index = current_user_wallpaper_index_ = ash::GetInvalidWallpaperIndex();
+    if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kEnableNewOobe)) {

[Nikita (slow), 2012/06/06 11:27:46]

This should be moved to InitializeWallpaper() to make this work as expected.

[bshe, 2012/06/08 15:06:30]

Right. Sorry I was in a hurry. I did check on my alex device but just check the
code path for "Add user" from user pod. Thanks for investigating it.

Done 

+      bool show_users;
+      CrosSettings::Get()->GetBoolean(kAccountsPrefShowUserNamesOnSignIn,
+                                      &show_users);
+      if (!show_users)
+        *index = current_user_wallpaper_index_ = ash::GetSolidColorIndex();
+    }
     return;
   }
 
   GetUserWallpaperProperties(GetLoggedInUser().email(), type, index);
 }
 
 void UserManagerImpl::SaveLoggedInUserWallpaperProperties(
     User::WallpaperType type,
     int index) {
   SaveUserWallpaperProperties(GetLoggedInUser().email(), type, index);
@@ skipping 476 matching lines @@
     BrowserThread::PostTask(
         BrowserThread::FILE,
         FROM_HERE,
         base::Bind(&UserManagerImpl::DeleteUserImage,
                    base::Unretained(this),
                    image_path));
   }
 }
 
 }  // namespace chromeos