Use a #fefefe solid color wallpaper background before user login for GAIA login flow

chrome/browser/chromeos/login/user_manager_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/user_manager_impl.h"
 
 #include <vector>
 
 #include "ash/shell.h"
 #include "ash/desktop_background/desktop_background_controller.h"
@@ skipping 343 matching lines @@
   NotifyOnLogin();
 }
 
 void UserManagerImpl::StubUserLoggedIn() {
   is_current_user_ephemeral_ = true;
   logged_in_user_ = new User(kStubUser, false);
   logged_in_user_->SetImage(GetDefaultImage(kStubDefaultImageIndex),
                             kStubDefaultImageIndex);
 }
 
-void UserManagerImpl::SetLoggedInUserWallpaper() {
+void UserManagerImpl::InitializeWallpaper() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
-  if (!IsUserLoggedIn() || IsLoggedInAsStub()) {
+  if (!IsUserLoggedIn()) {
+    if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kEnableNewOobe)) {
+      bool show_users;

[Daniel Erat, 2012/06/11 16:06:06]

initialize this to false or true.  you're ignoring the return value from
CrosSettings::GetBoolean(), so if the pref doesn't exist, i think that you'll be
reading uninitialized memory later.

[bshe, 2012/06/11 17:04:15]

Agree. 
We should probably also add a DCHECK here? This pref doesnt exist probably
suggests that there is a bug. Normally, for chromeos, this pref should always
registered. And the default value is true. 

On 2012/06/11 16:06:06, Daniel Erat wrote:

[Daniel Erat, 2012/06/11 17:12:10]

DCHECK sounds fine, but make sure you do:

  bool result = CrosSettings::Get()...;
  DCHECK(result) << "Unable to fetch setting " << kAccounts...;

instead of:

  DCHECK(CrosSettings::Get()...);

On 2012/06/11 17:04:15, bshe wrote:

+      CrosSettings::Get()->GetBoolean(kAccountsPrefShowUserNamesOnSignIn,
+                                      &show_users);
+      if (!show_users) {
+        ash::Shell::GetInstance()->desktop_background_controller()->
+            SetDefaultWallpaper(ash::GetSolidColorIndex());
+      }
+    }
+    return;
+  } else if (IsLoggedInAsStub()) {
     ash::Shell::GetInstance()->desktop_background_controller()->
         SetDefaultWallpaper(ash::GetInvalidWallpaperIndex());
     return;
   }
   UserSelected(GetLoggedInUser().email());
 }
 
 void UserManagerImpl::UserSelected(const std::string& email) {
   if (IsKnownUser(email)) {
     User::WallpaperType type;
@@ skipping 635 matching lines @@
                                     ash::GetDefaultWallpaperIndex());
       }
     }
   }
 }
 
 void UserManagerImpl::GetLoggedInUserWallpaperProperties(
     User::WallpaperType* type,
     int* index) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+  DCHECK(logged_in_user_);
 
-  if (!IsUserLoggedIn() || IsLoggedInAsStub()) {
+  if (IsLoggedInAsStub()) {
     *type = current_user_wallpaper_type_ = User::DEFAULT;
     *index = current_user_wallpaper_index_ = ash::GetInvalidWallpaperIndex();
     return;
   }
 
   GetUserWallpaperProperties(GetLoggedInUser().email(), type, index);
 }
 
 void UserManagerImpl::SaveLoggedInUserWallpaperProperties(
     User::WallpaperType type,
@@ skipping 490 matching lines @@
     BrowserThread::PostTask(
         BrowserThread::FILE,
         FROM_HERE,
         base::Bind(&UserManagerImpl::DeleteUserImage,
                    base::Unretained(this),
                    image_path));
   }
 }
 
 }  // namespace chromeos