[Sync] Refactor sync configuration logic.

chrome/browser/sync/glue/backend_data_type_configurer.h

Index: chrome/browser/sync/glue/backend_data_type_configurer.h
diff --git a/chrome/browser/sync/glue/backend_data_type_configurer.h b/chrome/browser/sync/glue/backend_data_type_configurer.h
index 161bc1437b9d6c0d0bc198dd545581c9a9fb8834..1b45cd0326f547ba5bb8ba2952e9146575c17a43 100644
--- a/chrome/browser/sync/glue/backend_data_type_configurer.h
+++ b/chrome/browser/sync/glue/backend_data_type_configurer.h
@@ -33,12 +33,12 @@ class BackendDataTypeConfigurer {
   // SyncBackendHost calls ConfigureDataTypes on itself to configure
   // Nigori.
   virtual void ConfigureDataTypes(
-      sync_api::ConfigureReason reason,
-      syncable::ModelTypeSet types_to_add,
-      syncable::ModelTypeSet types_to_remove,
+      const sync_api::ConfigureReason& reason,

[rlarocque, 2012/06/09 01:44:35]

nit: ConfigureReason is an enum.  It's probably better to just copy the value.

[Nicolas Zea, 2012/06/11 23:05:20]

Done.

+      const syncable::ModelTypeSet& types_to_add,
+      const syncable::ModelTypeSet& types_to_remove,
       NigoriState nigori_state,
-      base::Callback<void(syncable::ModelTypeSet)> ready_task,
-      base::Callback<void()> retry_callback) = 0;
+      const base::Callback<void(syncable::ModelTypeSet)>& ready_task,
+      const base::Callback<void()>& retry_callback) = 0;
 
  protected:
   virtual ~BackendDataTypeConfigurer() {}