Pepper Flash settings integration - camera and microphone.

chrome/browser/resources/options2/content_settings.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   /** @const */ var OptionsPage = options.OptionsPage;
 
   //////////////////////////////////////////////////////////////////////////////
   // ContentSettings class:
 
@@ skipping 65 matching lines @@
 
       if (cr.isChromeOS)
         UIAccountTweaks.applyGuestModeVisibility(document);
 
       // Cookies filter page ---------------------------------------------------
       $('show-cookies-button').onclick = function(event) {
         chrome.send('coreOptionsUserMetricsAction', ['Options_ShowCookies']);
         OptionsPage.navigateToPage('cookies');
       };
 
-      // Remove from DOM instead of hiding so :last-of-type applies the style
-      // correctly.
       var intentsSection = $('intents-section');
       if (!loadTimeData.getBoolean('enable_web_intents') && intentsSection)
         intentsSection.parentNode.removeChild(intentsSection);
 
       if (loadTimeData.getBoolean('enable_restore_session_state')) {
         this.sessionRestoreEnabled = true;
         this.updateSessionRestoreContentSettings();
       }
 
       $('content-settings-overlay-confirm').onclick =
           OptionsPage.closeOverlay.bind(OptionsPage);
+
+      $('pepper-flash-cameramic-section').style.display = 'none';
+      $('pepper-flash-cameramic-exceptions-div').style.display = 'none';

[csilv, 2012/06/05 00:40:21]

$('pepper-flash-cameramic-section').hidden = true;
$('pepper-flash-cameramic-exceptions-div').hidden = true;

[yzshen1, 2012/06/05 17:28:43]

I tried hidden before.
It worked with the section, but not the exceptions-dev.
But I didn't looked into why it didn't work.

Do you think I should make hidden work for the exceptions-div as well? (Would be
happy to do it if you think so.)
On 2012/06/05 00:40:21, csilv wrote:

[csilv, 2012/06/05 18:09:27]

That's okay, I'm fine with not using hidden for the reason you stated.  It would
be nice to figure out why it's not working, but not necessary for this CL.

     },
 
     /**
      * Called when the value of the "On startup" setting changes.
      * @param {Event} event Change event.
      * @private
      */
     onSessionRestoreSelectedChanged: function(event) {
       if (!event.value || typeof event.value['value'] == 'undefined')
         return;
@@ skipping 108 matching lines @@
    *     a content exception setting.
    */
   ContentSettings.patternValidityCheckComplete =
       function(type, mode, pattern, valid) {
     var exceptionsList =
         document.querySelector('div[contentType=' + type + '] ' +
                                'list[mode=' + mode + ']');
     exceptionsList.patternValidityCheckComplete(pattern, valid);
   };
 
+  /**
+   * Enables the Pepper Flash camera and microphone settings.
+   * Please note that whether the settings are actually showed or not is also
+   * affected by the style class pepper-flash-settings.
+   */
+  ContentSettings.enablePepperFlashCameraMicSettings = function() {
+    $('pepper-flash-cameramic-section').style.display = '';
+    $('pepper-flash-cameramic-exceptions-div').style.display = '';

[csilv, 2012/06/05 00:40:21]

$('pepper-flash-cameramic-section').hidden = false;
$('pepper-flash-cameramic-exceptions-div').hidden = false;

[yzshen1, 2012/06/05 17:28:43]

Please see my comment above.

On 2012/06/05 00:40:21, csilv wrote:

+  }
+
   // Export
   return {
     ContentSettings: ContentSettings
   };
 
 });