[net/dns] Only record HaveDnsChanged if the nameserver is not INADDR_ANY.

[net/dns] Only record HaveDnsChanged if the nameserver is not INADDR_ANY.

res_ninit will initialize the nameserver address to 0.0.0.0 if there are no nameservers in /etc/resolv.conf

BUG=125599, 130808

[mmenke, 2012-06-01 22:20:27]

http://codereview.chromium.org/10479005/diff/2001/net/base/host_resolver_impl.cc
File net/base/host_resolver_impl.cc (right):

http://codereview.chromium.org/10479005/diff/2001/net/base/host_resolver_impl...
net/base/host_resolver_impl.cc:1972: if (dns_config.nameservers[0].address()[0])
{
Is it possible that we'd have INADDR_ANY, followed by other addresses?  If not,
LGTM.  If so, might want to check for that.

http://codereview.chromium.org/10479005/diff/2001/net/base/host_resolver_impl...
net/base/host_resolver_impl.cc:1974: }
nit:  No brackets for single-line ifs.

[mmenke, 2012-06-01 22:21:20]

http://codereview.chromium.org/10479005/diff/2001/net/base/host_resolver_impl.cc
File net/base/host_resolver_impl.cc (right):

http://codereview.chromium.org/10479005/diff/2001/net/base/host_resolver_impl...
net/base/host_resolver_impl.cc:1974: }
On 2012/06/01 22:20:27, Matt Menke wrote:
> nit:  No brackets for single-line ifs.

Actually, I'm never sure if that is optional or not...Know it's been discussed
before.  Erm...I really don't care.

[mmenke, 2012-06-01 22:24:14]

http://codereview.chromium.org/10479005/diff/2001/net/base/host_resolver_impl.cc
File net/base/host_resolver_impl.cc (right):

http://codereview.chromium.org/10479005/diff/2001/net/base/host_resolver_impl...
net/base/host_resolver_impl.cc:1974: }
On 2012/06/01 22:21:20, Matt Menke wrote:
> On 2012/06/01 22:20:27, Matt Menke wrote:
> > nit:  No brackets for single-line ifs.
> 
> Actually, I'm never sure if that is optional or not...Know it's been discussed
> before.  Erm...I really don't care.

Ahh, chromium style guide:

Other formatting "rules" are not required, but are fairly common across Chrome
code, and thus it's probably best to stick to them unless you have a reason not
to.  In particular, if existing code follows these styles, maintain them:
* Prefer (foo == 0) to (0 == foo)
* Omit {} for conditional or loop bodies where the body is just one physical
line.  Otherwise, use {}.
* Function declaration order should match function definition order

[szym, 2012-06-11 19:52:33]

This CL has been replaced by:
http://codereview.chromium.org/10546081/