[cros] Change how we track momemt to emit login-prompt-visible signal.

chrome/common/chrome_notification_types.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_COMMON_CHROME_NOTIFICATION_TYPES_H_
 #define CHROME_COMMON_CHROME_NOTIFICATION_TYPES_H_
 #pragma once
 
 #include "content/public/browser/notification_types.h"
 
@@ skipping 873 matching lines @@
 
   // Sent when webui lock screen is ready.
   NOTIFICATION_LOCK_WEBUI_READY,
 
   // Sent when webui login screen is ready and gaia iframe has loaded.
   NOTIFICATION_LOGIN_WEBUI_READY,
 
   // Sent when the user images on the WebUI login screen have all been loaded.
   NOTIFICATION_LOGIN_USER_IMAGES_LOADED,
 
+  // Sent when the login WebUI is considered to be fully visible.
+  // That momemnt is tracked as the first paint event after one of the:
+  // 1. NOTIFICATION_LOGIN_USER_IMAGES_LOADED

[Daniel Erat, 2012/06/02 14:20:59]

Can you delete some of these, too?  I only added the _USER_IMAGES_LOADED
notification so we could tell when the WebUI is visible -- if it's not needed in
order to send the _WEBUI_VISIBLE notification, I think that it can be removed.

[Nikita (slow), 2012/06/04 09:03:21]

I think it makes sense to leave this _USER_IMAGES_LOADED notification.

They are used by automation proxy.

Even though they may be seen as duplicating _WEBUI_VISIBLE but in fact
_WEBUI_VISIBLE just says that one of the parts of WebUI login is ready/visible,
those 4 others say specifically which one is ready to be used and was shown.

Current usage in automation proxy is when on of the
_USER_IMAGES_LOADED, _LOGIN_WEBUI_READY, _WIZARD_FIRST_SCREEN_SHOWN is firedm
report event "WebUI ready". But we may as well improve on that and require
specific notification.

For instance when we're booting into image w/o users we're waiting for
_LOGIN_WEBUI_READY, not for _USER_IMAGES_LOADED.

+  // 2. NOTIFICATION_LOGIN_WEBUI_READY
+  // 3. NOTIFICATION_LOGIN_NETWORK_ERROR_SHOWN
+  // 4. NOTIFICATION_WIZARD_FIRST_SCREEN_SHOWN
+  NOTIFICATION_LOGIN_WEBUI_VISIBLE,
+
   // Sent when proxy dialog is closed.
   NOTIFICATION_LOGIN_PROXY_CHANGED,
 
   // Sent when a network error message is displayed on the WebUI login screen.
   NOTIFICATION_LOGIN_NETWORK_ERROR_SHOWN,
 
   // Sent when the user list has changed due to a policy change.
   NOTIFICATION_POLICY_USER_LIST_CHANGED,
 
   // Sent when a panel state changed.
@@ skipping 206 matching lines @@
   // Currently only Content and Chrome define and use notifications.
   // Custom notifications not belonging to Content and Chrome should start
   // from here.
   NOTIFICATION_CHROME_END,
 };
 
 }  // namespace chrome
 
 
 #endif  // CHROME_COMMON_CHROME_NOTIFICATION_TYPES_H_