runtime/vm/stub_code_ia32.cc - Issue 10458031: In generated code for x64 don't load object's class directly from class_ field.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/stub_code_ia32.cc

Issue 10458031: In generated code for x64 don't load object's class directly from class_ field. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: CoreClass in flow_graph_compiler_x64.cc should return RawClass* Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/stub_code_ia32.cc

diff --git a/runtime/vm/stub_code_ia32.cc b/runtime/vm/stub_code_ia32.cc

index 2fb028957181789309098f9c087ae1847b608cc0..42d5a68172ccc6c01b5df306bae657735fe6dabf 100644

--- a/runtime/vm/stub_code_ia32.cc

+++ b/runtime/vm/stub_code_ia32.cc

@@ -1591,7 +1591,6 @@ void StubCode::GenerateNArgsCheckInlineCacheStub(Assembler* assembler,

#endif // DEBUG

// Loop that checks if there is an IC data match.

- // EAX: receiver's class.

Ivan Posva 2012/05/30 18:15:19 Thanks!

// ECX: IC data object (preserved).

__ movl(EBX, FieldAddress(ECX, ICData::ic_data_offset()));

// EBX: ic_data_array with check entries: classes and target functions.

« runtime/vm/flow_graph_compiler_x64.cc ('K') | « runtime/vm/intermediate_language_x64.cc ('k') | runtime/vm/stub_code_x64.cc » ('j') | no next file with comments »