Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 10458018: This CL does the following: (1) Pass the max_length attribute to the password generator; (2) Update… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Futher comments. Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/browser_view.cc
diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc
index eff052e4305da3b3e31d03d0ebde8abca37316e3..f24de2c25b2c672dee1b9c3ef47645268ecc7d1c 100644
--- a/chrome/browser/ui/views/frame/browser_view.cc
+++ b/chrome/browser/ui/views/frame/browser_view.cc
@@ -2403,7 +2403,9 @@ void BrowserView::ShowAvatarBubbleFromAvatarButton() {
button->ShowAvatarBubble();
}
-void BrowserView::ShowPasswordGenerationBubble(const gfx::Rect& rect) {
+void BrowserView::ShowPasswordGenerationBubble(
+ const gfx::Rect& rect,
+ autofill::PasswordGenerator* password_generator) {
// Create a rect in the content bounds that the bubble will point to.
gfx::Point origin(rect.origin());
views::View::ConvertPointToScreen(GetTabContentsContainerView(), &origin);
@@ -2417,7 +2419,8 @@ void BrowserView::ShowPasswordGenerationBubble(const gfx::Rect& rect) {
PasswordGenerationBubbleView* bubble =
new PasswordGenerationBubbleView(bounds,
this,
- web_contents->GetRenderViewHost());
+ web_contents->GetRenderViewHost(),
+ password_generator);
views::BubbleDelegateView::CreateBubble(bubble);
bubble->SetAlignment(views::BubbleBorder::ALIGN_EDGE_TO_ANCHOR_EDGE);
bubble->Show();

Powered by Google App Engine
This is Rietveld 408576698