chrome/browser/ui/views/frame/browser_view.cc - Issue 10458018: This CL does the following: (1) Pass the max_length attribute to the password generator; (2) Update…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 10458018: This CL does the following: (1) Pass the max_length attribute to the password generator; (2) Update… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix a bug in Windows UI. Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/autofill/password_generator_unittest.cc ('K') | « chrome/browser/ui/views/frame/browser_view.h ('k') | chrome/browser/ui/views/password_generation_bubble_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/frame/browser_view.cc

diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc

index eff052e4305da3b3e31d03d0ebde8abca37316e3..3bc3828974a9c8037ae629c1620b8de30f89339a 100644

--- a/chrome/browser/ui/views/frame/browser_view.cc

+++ b/chrome/browser/ui/views/frame/browser_view.cc

@@ -2403,7 +2403,8 @@ void BrowserView::ShowAvatarBubbleFromAvatarButton() {

button->ShowAvatarBubble();

}

-void BrowserView::ShowPasswordGenerationBubble(const gfx::Rect& rect) {

+void BrowserView::ShowPasswordGenerationBubble(const gfx::Rect& rect,

+ int max_length) {

// Create a rect in the content bounds that the bubble will point to.

gfx::Point origin(rect.origin());

views::View::ConvertPointToScreen(GetTabContentsContainerView(), &origin);

@@ -2416,6 +2417,7 @@ void BrowserView::ShowPasswordGenerationBubble(const gfx::Rect& rect) {

PasswordGenerationBubbleView* bubble =

new PasswordGenerationBubbleView(bounds,

+ max_length,

this,

web_contents->GetRenderViewHost());

views::BubbleDelegateView::CreateBubble(bubble);