chrome/browser/ui/gtk/password_generation_bubble_gtk.cc - Issue 10458018: This CL does the following: (1) Pass the max_length attribute to the password generator; (2) Update…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/password_generation_bubble_gtk.cc

Issue 10458018: This CL does the following: (1) Pass the max_length attribute to the password generator; (2) Update… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix a bug in Windows UI. Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/autofill/password_generator_unittest.cc ('K') | « chrome/browser/ui/gtk/password_generation_bubble_gtk.h ('k') | chrome/browser/ui/views/frame/browser_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/gtk/password_generation_bubble_gtk.cc

diff --git a/chrome/browser/ui/gtk/password_generation_bubble_gtk.cc b/chrome/browser/ui/gtk/password_generation_bubble_gtk.cc

index 2215496cb039786b4347b5bd1a70c8f31011ec8b..d9525192997f547556effc95740c49f13e8b4889 100644

--- a/chrome/browser/ui/gtk/password_generation_bubble_gtk.cc

+++ b/chrome/browser/ui/gtk/password_generation_bubble_gtk.cc

@@ -24,6 +24,7 @@ const int kHorizontalSpacing = 4;

PasswordGenerationBubbleGtk::PasswordGenerationBubbleGtk(

const gfx::Rect& anchor_rect,

+ int max_length,

GtkWidget* anchor_widget,

Profile* profile,

content::RenderViewHost* render_view_host)

@@ -47,7 +48,7 @@ PasswordGenerationBubbleGtk::PasswordGenerationBubbleGtk(

GtkWidget* password_line = gtk_hbox_new(FALSE, kHorizontalSpacing);

text_field_ = gtk_entry_new();

gtk_entry_set_text(GTK_ENTRY(text_field_),

- password_generator_.Generate().c_str());

+ password_generator_.Generate(max_length).c_str());

gtk_entry_set_max_length(GTK_ENTRY(text_field_), 15);

GtkWidget* accept_button = gtk_button_new_with_label("Try It");

gtk_box_pack_start(GTK_BOX(password_line), text_field_, TRUE, TRUE, 0);