chrome/browser/ui/gtk/browser_window_gtk.cc - Issue 10458018: This CL does the following: (1) Pass the max_length attribute to the password generator; (2) Update…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/browser_window_gtk.cc

Issue 10458018: This CL does the following: (1) Pass the max_length attribute to the password generator; (2) Update… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix a bug in Windows UI. Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/autofill/password_generator_unittest.cc ('K') | « chrome/browser/ui/gtk/browser_window_gtk.h ('k') | chrome/browser/ui/gtk/password_generation_bubble_gtk.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/gtk/browser_window_gtk.cc

diff --git a/chrome/browser/ui/gtk/browser_window_gtk.cc b/chrome/browser/ui/gtk/browser_window_gtk.cc

index bfa8fe878f1b678ebf75956b22cca33e20b0baed..0170340ecd40db6edb94063b50bc5b34e6b47f3e 100644

--- a/chrome/browser/ui/gtk/browser_window_gtk.cc

+++ b/chrome/browser/ui/gtk/browser_window_gtk.cc

@@ -1290,13 +1290,15 @@ void BrowserWindowGtk::ShowAvatarBubbleFromAvatarButton() {

titlebar_->avatar_button()->ShowAvatarBubble();

}

-void BrowserWindowGtk::ShowPasswordGenerationBubble(const gfx::Rect& rect) {

+void BrowserWindowGtk::ShowPasswordGenerationBubble(const gfx::Rect& rect,

+ int max_length) {

WebContents* web_contents = browser_->GetSelectedWebContents();

if (!web_contents || !web_contents->GetContentNativeView()) {

return;

}

new PasswordGenerationBubbleGtk(rect,

+ max_length,

web_contents->GetContentNativeView(),

browser()->profile(),

web_contents->GetRenderViewHost());