This CL does the following: (1) Pass the max_length attribute to the password generator; (2) Update…

chrome/browser/autofill/autofill_manager.cc

Index: chrome/browser/autofill/autofill_manager.cc
diff --git a/chrome/browser/autofill/autofill_manager.cc b/chrome/browser/autofill/autofill_manager.cc
index 146c42923b90c724f4d569dc38f407cb45adf0ce..ceb325b0f383473a29fc75644f8d5b7c65d675ab 100644
--- a/chrome/browser/autofill/autofill_manager.cc
+++ b/chrome/browser/autofill/autofill_manager.cc
@@ -28,6 +28,7 @@
 #include "chrome/browser/autofill/autofill_type.h"
 #include "chrome/browser/autofill/credit_card.h"
 #include "chrome/browser/autofill/form_structure.h"
+#include "chrome/browser/autofill/password_generator.h"
 #include "chrome/browser/autofill/personal_data_manager.h"
 #include "chrome/browser/autofill/personal_data_manager_factory.h"
 #include "chrome/browser/autofill/phone_number.h"
@@ -717,13 +718,17 @@ void AutofillManager::OnHideAutofillPopup() {
     external_delegate_->HideAutofillPopup();
 }
 
-void AutofillManager::OnShowPasswordGenerationPopup(const gfx::Rect& bounds) {
+void AutofillManager::OnShowPasswordGenerationPopup(const gfx::Rect& bounds,
+                                                    int max_length) {
 #if defined(OS_ANDROID)
   NOTIMPLEMENTED();
 #else
   Browser* browser = browser::FindLastActiveWithProfile(
       Profile::FromBrowserContext(web_contents()->GetBrowserContext()));
-  browser->window()->ShowPasswordGenerationBubble(bounds);
+  scoped_ptr<autofill::PasswordGenerator> password_generator(
+      new autofill::PasswordGenerator(max_length));

[Ilya Sherman, 2012/06/04 21:17:52]

This will be freed as soon as the method call returns.  If you want this to
outlive the method call, you'll need to store it as a member variable in the
AutofillManager class.

Alternately, if you mean to transfer the ownership, you should call
password_generator.release() below, and document the transfer of ownership very
explicitly in comments for all of the affected interfaces.

[zysxqn, 2012/06/04 22:40:15]

Originally I did mean to transfer the ownership -- limiting the lifetime of
password_generator to be the same as the UI is sufficient for now. After a
second thought, I decided to make it a member variable in the AutofillManager
class so it will live longer - it could be useful later when we need some data
about the generated passwords.

+  browser->window()->ShowPasswordGenerationBubble(
+      bounds, password_generator.get());
 #endif  // #if defined(OS_ANDROID)
 }