Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Unified Diff: chrome/browser/ui/gtk/password_generation_bubble_gtk.h

Issue 10458018: This CL does the following: (1) Pass the max_length attribute to the password generator; (2) Update… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Make password generator independent of platforms. Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/gtk/password_generation_bubble_gtk.h
diff --git a/chrome/browser/ui/gtk/password_generation_bubble_gtk.h b/chrome/browser/ui/gtk/password_generation_bubble_gtk.h
index 1de4e2d205b844b7e4f161eff703ac4a8be5b3da..ac92a329491d7a12ff5682af9f37d17c8a3a50f2 100644
--- a/chrome/browser/ui/gtk/password_generation_bubble_gtk.h
+++ b/chrome/browser/ui/gtk/password_generation_bubble_gtk.h
@@ -8,10 +8,14 @@
#include <gtk/gtk.h>
-#include "chrome/browser/autofill/password_generator.h"
+#include "base/basictypes.h"
#include "ui/base/gtk/gtk_signal.h"
#include "ui/gfx/rect.h"
+namespace autofill {
+class PasswordGenerator;
+}
+
namespace content {
class RenderViewHost;
}
@@ -28,7 +32,8 @@ class PasswordGenerationBubbleGtk {
PasswordGenerationBubbleGtk(const gfx::Rect& anchor_rect,
GtkWidget* anchor_widget,
Profile* profile,
- content::RenderViewHost* render_view_host);
+ content::RenderViewHost* render_view_host,
+ autofill::PasswordGenerator* password_generator);
virtual ~PasswordGenerationBubbleGtk();
private:
@@ -44,8 +49,8 @@ class PasswordGenerationBubbleGtk {
// RenderViewHost associated with the button that spawned this bubble.
content::RenderViewHost* render_view_host_;
- // Class that deals with generating passwords.
- autofill::PasswordGenerator password_generator_;
+ // Object that deals with generating passwords.
+ autofill::PasswordGenerator* password_generator_;
DISALLOW_COPY_AND_ASSIGN(PasswordGenerationBubbleGtk);
};

Powered by Google App Engine
This is Rietveld 408576698