This CL does the following: (1) Pass the max_length attribute to the password generator; (2) Update…

chrome/browser/ui/views/password_generation_bubble_view.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_PASSWORD_GENERATION_BUBBLE_VIEW_H_
 #define CHROME_BROWSER_UI_VIEWS_PASSWORD_GENERATION_BUBBLE_VIEW_H_
 #pragma once
 
-#include "chrome/browser/autofill/password_generator.h"
+#include "base/basictypes.h"
 #include "ui/gfx/rect.h"
 #include "ui/views/bubble/bubble_delegate.h"
 #include "ui/views/controls/button/button.h"
 #include "ui/views/controls/link_listener.h"
 #include "ui/views/view.h"
 #include "webkit/forms/password_form.h"
 
+namespace autofill {
+class PasswordGenerator;
+}
+
 namespace content {
 class PageNavigator;
 class RenderViewHost;
 }
 
 namespace views {
 class TextButton;
 class Textfield;
 }
 
 class PasswordManager;
 
 // PasswordGenerationBubbleView is a bubble used to show possible generated
 // passwords to users. It is set in the page content, anchored at |anchor_rect|.
 // If the generated password is accepted by the user, the renderer associated
 // with |render_view_host| and the |password_manager| are informed.
 class PasswordGenerationBubbleView : public views::BubbleDelegateView,
                                      public views::ButtonListener,
                                      public views::LinkListener {
  public:
   PasswordGenerationBubbleView(const gfx::Rect& anchor_rect,
                                const webkit::forms::PasswordForm& form,
                                views::View* anchor_view,
                                content::RenderViewHost* render_view_host,
+                               autofill::PasswordGenerator* password_generator);
                                content::PageNavigator* navigator,
                                PasswordManager* password_manager);
   virtual ~PasswordGenerationBubbleView();
 
  private:
   // views::BubbleDelegateView
   virtual void Init() OVERRIDE;
   virtual gfx::Rect GetAnchorRect() OVERRIDE;
 
   // views::ButtonListener
@@ skipping 12 matching lines @@
 
   // Location that the bubble points to
   gfx::Rect anchor_rect_;
 
   // The form associated with the password field(s) that we are generated.
   webkit::forms::PasswordForm form_;
 
   // RenderViewHost associated with the button that spawned this bubble.
   content::RenderViewHost* render_view_host_;
 
+  // Object to generate passwords
+  autofill::PasswordGenerator* password_generator_;

[sky, 2012/06/06 04:04:07]

Document ownership.

[zysxqn, 2012/06/06 16:43:59]

Done.

+
   // An object used to handle page loads that originate from link clicks
   // within this UI.
   content::PageNavigator* navigator_;
 
   // PasswordManager associated with this tab.
   PasswordManager* password_manager_;
 
-  // Class to generate passwords
-  autofill::PasswordGenerator password_generator_;
-
   DISALLOW_COPY_AND_ASSIGN(PasswordGenerationBubbleView);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_PASSWORD_GENERATION_BUBBLE_VIEW_H_