This CL does the following: (1) Pass the max_length attribute to the password generator; (2) Update…

chrome/browser/ui/browser_window.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_BROWSER_WINDOW_H_
 #define CHROME_BROWSER_UI_BROWSER_WINDOW_H_
 #pragma once
 
 #include "base/callback_forward.h"
 #include "chrome/browser/lifetime/application_lifetime.h"
@@ skipping 14 matching lines @@
 class LocationBar;
 class Profile;
 class StatusBubble;
 class TabContents;
 typedef TabContents TabContentsWrapper;
 class TemplateURL;
 #if !defined(OS_MACOSX)
 class ToolbarView;
 #endif
 
+namespace autofill {
+class PasswordGenerator;
+}
 namespace content {
 class WebContents;
 struct NativeWebKeyboardEvent;
 struct SSLStatus;
 }
 
 namespace extensions {
 class Extension;
 }
 
@@ skipping 333 matching lines @@
 
   // Shows the avatar bubble on the window frame off of the avatar button.
   virtual void ShowAvatarBubbleFromAvatarButton() = 0;
 
   // Show bubble for password generation positioned relative to |rect|. |form|
   // is the form that contains the password field that the bubble will be
   // associated with. A stub implementation is provided since this feature is
   // currently not available on mac.
   virtual void ShowPasswordGenerationBubble(
       const gfx::Rect& rect,
+      autofill::PasswordGenerator* password_generator,

[sky, 2012/06/06 04:04:07]

Document ownership of |password_generator|

[zysxqn, 2012/06/06 16:43:59]

Done.

       const webkit::forms::PasswordForm& form) {}
 
  protected:
   friend void browser::CloseAllBrowsers();
   friend class BrowserView;
   virtual void DestroyBrowser() = 0;
 };
 
 #if defined(OS_WIN) || defined(TOOLKIT_VIEWS)
 class BookmarkBarView;
@@ skipping 20 matching lines @@
 
   // Returns the ToolbarView.
   virtual ToolbarView* GetToolbarView() const = 0;
 #endif
 
  protected:
   virtual ~BrowserWindowTesting() {}
 };
 
 #endif  // CHROME_BROWSER_UI_BROWSER_WINDOW_H_