This CL does the following: (1) Pass the max_length attribute to the password generator; (2) Update…

chrome/browser/ui/views/password_generation_bubble_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/password_generation_bubble_view.h"
 
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/autofill/password_generator.h"
 #include "chrome/common/autofill_messages.h"
 #include "content/public/browser/render_view_host.h"
 #include "ui/views/controls/button/text_button.h"
 #include "ui/views/controls/label.h"
 #include "ui/views/controls/textfield/textfield.h"
 #include "ui/views/layout/grid_layout.h"
 #include "ui/views/layout/layout_constants.h"
 
 using views::ColumnSet;
 using views::GridLayout;
 
 PasswordGenerationBubbleView::PasswordGenerationBubbleView(
     const gfx::Rect& anchor_rect,
     views::View* anchor_view,
-    content::RenderViewHost* render_view_host)
+    content::RenderViewHost* render_view_host,
+    autofill::PasswordGenerator* password_generator)
     : BubbleDelegateView(anchor_view, views::BubbleBorder::TOP_LEFT),
       accept_button_(NULL),
       text_field_(NULL),
       anchor_rect_(anchor_rect),
-      render_view_host_(render_view_host) {}
+      render_view_host_(render_view_host),
+      password_generator_(password_generator) {}
 
 PasswordGenerationBubbleView::~PasswordGenerationBubbleView() {}
 
 void PasswordGenerationBubbleView::Init() {
   // TODO(gcasto): Localize text after we have finalized the UI.
   // crbug.com/118062
   accept_button_ = new views::NativeTextButton(this,
                                                ASCIIToUTF16("Try It"));
 
   text_field_ = new views::Textfield();
-  text_field_->SetText(ASCIIToUTF16(password_generator_.Generate()));
+  text_field_->SetText(
+      ASCIIToUTF16(password_generator_->Generate()));
 
   views::Label* title_label = new views::Label(
       ASCIIToUTF16("Password Suggestion"));
 
   GridLayout* layout = new GridLayout(this);
   SetLayoutManager(layout);
 
   // Title row.
   ColumnSet* cs = layout->AddColumnSet(0);
   cs->AddColumn(GridLayout::CENTER, GridLayout::CENTER, 0,
@@ skipping 20 matching lines @@
 }
 
 void PasswordGenerationBubbleView::ButtonPressed(views::Button* sender,
                                                  const views::Event& event) {
   if (sender == accept_button_) {
     render_view_host_->Send(new AutofillMsg_GeneratedPasswordAccepted(
         render_view_host_->GetRoutingID(), text_field_->text()));
     StartFade(false);
   }
 }