This CL does the following: (1) Pass the max_length attribute to the password generator; (2) Update…

chrome/browser/autofill/password_generator.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_AUTOFILL_PASSWORD_GENERATOR_H_
 #define CHROME_BROWSER_AUTOFILL_PASSWORD_GENERATOR_H_
 #pragma once
 
 #include <string>
 
 #include "base/basictypes.h"
 
 namespace autofill {
 
 // Class to generate random passwords. Currently we just use a generic algorithm
 // for all sites, but eventually we can incorporate additional information to
 // determine passwords that are likely to be accepted (i.e. use pattern field,
 // previous generated passwords, crowdsourcing, etc.)
 class PasswordGenerator {
  public:
   PasswordGenerator();
   ~PasswordGenerator();
 
   // Returns a random password. The string is guaranteed to be printable and
-  // will not include whitespace characters.
-  std::string Generate();
+  // will not include whitespace characters. Furthermore, it has a maximum
+  // length specified by the |max_length|, and contains AT LEAST one upper
+  // case letter, one lower case letter, one digit, and one other symbol.
+  std::string Generate(int max_length);

[Garrett Casto, 2012/05/30 00:46:35]

I was wondering if we might want to change the way that we create the
PasswordGenerator. Right now the bubble itself owns the generator, which has
some limitations.

1) The lifetime of the generator is bound to the bubble.
2) We need to change each bubble implementation whenever we change how the
generator works.

I was thinking that it would be better to pass in a PasswordGenerator when we
instantiate a bubble. This means that the UI code doesn't need to know about how
we generate the password, since that information isn't UI specific. It should
make changing this easier in the future, like when we want to use the pattern
attribute.

Alternatively we can have a parent class for all the bubbles. This has the
advantage that it makes adding things like UMA stats much easier when the time
comes for that.

[zysxqn, 2012/05/31 21:54:08]

I like the idea of passing a PasswordGenerator to the bubble. Changed.

 
  private:
 
   DISALLOW_COPY_AND_ASSIGN(PasswordGenerator);
 };
 
 }  // namespace autofill
 
 #endif  // CHROME_BROWSER_AUTOFILL_PASSWORD_GENERATOR_H_