This CL does the following: (1) Pass the max_length attribute to the password generator; (2) Update…

chrome/browser/ui/browser_window.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_BROWSER_WINDOW_H_
 #define CHROME_BROWSER_UI_BROWSER_WINDOW_H_
 #pragma once
 
 #include "base/callback_forward.h"
 #include "chrome/browser/lifetime/application_lifetime.h"
@@ skipping 11 matching lines @@
 class GURL;
 class LocationBar;
 class Profile;
 class StatusBubble;
 class TabContentsWrapper;
 class TemplateURL;
 #if !defined(OS_MACOSX)
 class ToolbarView;
 #endif
 
+namespace autofill {
+class PasswordGenerator;
+}
 namespace content {
 class WebContents;
 struct NativeWebKeyboardEvent;
 struct SSLStatus;
 }
 
 namespace extensions {
 class Extension;
 }
 
@@ skipping 312 matching lines @@
   // system.
   virtual void ShowAvatarBubble(content::WebContents* web_contents,
                                 const gfx::Rect& rect) = 0;
 
   // Shows the avatar bubble on the window frame off of the avatar button.
   virtual void ShowAvatarBubbleFromAvatarButton() = 0;
 
   // Show bubble for password generation positioned relative to |rect|. A stub
   // implementation is provided since this feature is currently only available
   // for Windows.
-  virtual void ShowPasswordGenerationBubble(const gfx::Rect& rect) {}
+  virtual void ShowPasswordGenerationBubble(
+      const gfx::Rect& rect,
+      autofill::PasswordGenerator* password_generator) {}

[Ilya Sherman, 2012/06/04 21:17:52]

This default implementation should be careful not to leak the
|password_generator| if you decide on a transfer-of-ownership semantics.

[zysxqn, 2012/06/04 22:40:15]

NA now.

 
  protected:
   friend void browser::CloseAllBrowsers();
   friend class BrowserView;
   virtual void DestroyBrowser() = 0;
 };
 
 #if defined(OS_WIN) || defined(TOOLKIT_VIEWS)
 class BookmarkBarView;
 class LocationBarView;
@@ skipping 19 matching lines @@
 
   // Returns the ToolbarView.
   virtual ToolbarView* GetToolbarView() const = 0;
 #endif
 
  protected:
   virtual ~BrowserWindowTesting() {}
 };
 
 #endif  // CHROME_BROWSER_UI_BROWSER_WINDOW_H_