This CL does the following: (1) Pass the max_length attribute to the password generator; (2) Update…

chrome/browser/autofill/password_generator_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <locale>
 
 #include "chrome/browser/autofill/password_generator.h"
 
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace autofill {
 
-TEST(PasswordGeneratorTest, PasswordGeneratorSimpleTest) {
-  // Not much to test, just make sure that the characters in a generated
-  // password are reasonable.
+TEST(PasswordGeneratorTest, TestPasswordLength) {

[Ilya Sherman, 2012/06/01 01:09:55]

nit: "TestPasswordLength" -> "PasswordLength" (and likewise for the other tests
in this file)

[zysxqn, 2012/06/01 19:01:32]

Done.

+  PasswordGenerator pg1(10);
+  std::string password = pg1.Generate();
+  EXPECT_EQ(password.size(), 10u);

[Ilya Sherman, 2012/06/01 01:09:55]

nit: Please add a blank line after this line.

[zysxqn, 2012/06/01 19:01:32]

Done.

+  PasswordGenerator pg2(-1);
+  password = pg2.Generate();
+  EXPECT_EQ(password.size(), kDefaultPasswordLength);

[Ilya Sherman, 2012/06/01 01:09:55]

nit: Please add a blank line after this line.

[zysxqn, 2012/06/01 19:01:32]

Done.

+  PasswordGenerator pg3(100);
+  password = pg3.Generate();
+  EXPECT_EQ(password.size(), kDefaultPasswordLength);
+}
+
+TEST(PasswordGeneratorTest, TestPasswordPattern) {
+  PasswordGenerator pg;
+  std::string password = pg.Generate();
+  int num_upper_case_letters = 0;
+  int num_lower_case_letters = 0;
+  int num_digits = 0;
+  int num_other_symbols = 0;
+  for (size_t i = 0; i < password.size(); i++) {
+    if (isupper(password[i]))
+      ++num_upper_case_letters;
+    else if (islower(password[i]))
+      ++num_lower_case_letters;
+    else if (isdigit(password[i]))
+      ++num_digits;
+    else
+      ++num_other_symbols;
+  }
+  EXPECT_GT(num_upper_case_letters, 0);
+  EXPECT_GT(num_lower_case_letters, 0);
+  EXPECT_GT(num_digits, 0);
+  EXPECT_GT(num_other_symbols, 0);
+}
+
+TEST(PasswordGeneratorTest, TestPrintable) {
   PasswordGenerator pg;
   std::string password = pg.Generate();
   for (size_t i = 0; i < password.size(); i++) {
     // Make sure that the character is printable.
     EXPECT_TRUE(isgraph(password[i]));
   }
 }
 
 }  // namespace autofill