Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 10457002: Add native debugging support for no-root mode (Closed)

Created:
8 years, 7 months ago by haitao.feng
Modified:
8 years, 6 months ago
Reviewers:
John Grabowski, jrg
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add native debugging support for no-root mode BUG= TEST=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -9 lines) Patch
M build/android/gdb_content_shell View 2 chunks +6 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
haitao.feng
Hello I'd like you to review my code.
8 years, 7 months ago (2012-05-28 05:16:45 UTC) #1
John Grabowski
Exellent! Does this finish the job (e.g. does gdb completely work now? LGTM but please ...
8 years, 6 months ago (2012-05-29 17:52:52 UTC) #2
haitao.feng
Thanks for your review. gdb works. I am using this script to debug the content ...
8 years, 6 months ago (2012-05-30 00:15:14 UTC) #3
haitao.feng
Added my name in the AUTHORS.
8 years, 6 months ago (2012-05-30 06:13:30 UTC) #4
John Grabowski
Thanks. Send it in!
8 years, 6 months ago (2012-05-30 18:38:43 UTC) #5
haitao.feng
On 2012/05/30 18:38:43, John Grabowski wrote: > Thanks. Send it in! It seems that CQ ...
8 years, 6 months ago (2012-05-31 05:05:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haitao.feng@intel.com/10457002/3001
8 years, 6 months ago (2012-05-31 05:36:03 UTC) #7
jrg
I just clicked the commit box On Wed, May 30, 2012 at 10:05 PM, <haitao.feng@intel.com> ...
8 years, 6 months ago (2012-05-31 05:36:05 UTC) #8
commit-bot: I haz the power
Failed to apply patch for AUTHORS: While running patch -p1 --forward --force; patching file AUTHORS ...
8 years, 6 months ago (2012-05-31 05:36:05 UTC) #9
haitao.feng
8 years, 6 months ago (2012-05-31 06:02:19 UTC) #10
haitao.feng
On 2012/05/31 06:02:19, haitao.feng wrote: I have solved the AUTHORS conflict. Sorry I have done ...
8 years, 6 months ago (2012-05-31 06:04:36 UTC) #11
jrg
8 years, 6 months ago (2012-05-31 06:07:05 UTC) #12
done and CQ box checkec


On Wed, May 30, 2012 at 11:04 PM, <haitao.feng@intel.com> wrote:

> On 2012/05/31 06:02:19, haitao.feng wrote:
>
> I have solved the AUTHORS conflict. Sorry I have done some local
> operations on
> git tree and now the review is uploaded at
>
https://chromiumcodereview.**appspot.com/10448096<https://chromiumcodereview.....
> Could you help to try that?
>
>
http://codereview.chromium.**org/10457002/<http://codereview.chromium.org/104...
>

Powered by Google App Engine
This is Rietveld 408576698