Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: sync/engine/sync_scheduler.cc

Issue 10455012: [Sync] Add support for performing a GetKey on startup. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Move GetEncryptionKey logic into GetUpdates Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/engine/sync_scheduler.cc
diff --git a/sync/engine/sync_scheduler.cc b/sync/engine/sync_scheduler.cc
index c351326e70ccf10769624a55f3710d5e51084aa3..3bad05128c1a4479ee68457d94efb47e7127a5d8 100644
--- a/sync/engine/sync_scheduler.cc
+++ b/sync/engine/sync_scheduler.cc
@@ -66,18 +66,15 @@ bool IsActionableError(
} // namespace
ConfigurationParams::ConfigurationParams()
- : source(GetUpdatesCallerInfo::UNKNOWN),
- keystore_key_status(KEYSTORE_KEY_UNNECESSARY) {}
+ : source(GetUpdatesCallerInfo::UNKNOWN) {}
ConfigurationParams::ConfigurationParams(
const sync_pb::GetUpdatesCallerInfo::GetUpdatesSource& source,
const syncer::ModelTypeSet& types_to_download,
const syncer::ModelSafeRoutingInfo& routing_info,
- KeystoreKeyStatus keystore_key_status,
const base::Closure& ready_task)
: source(source),
types_to_download(types_to_download),
routing_info(routing_info),
- keystore_key_status(keystore_key_status),
ready_task(ready_task) {
DCHECK(!ready_task.is_null());
}
@@ -353,15 +350,8 @@ bool SyncScheduler::ScheduleConfiguration(const ConfigurationParams& params) {
&restricted_workers);
session_context_->set_routing_info(params.routing_info);
- if (params.keystore_key_status == ConfigurationParams::KEYSTORE_KEY_NEEDED) {
- // TODO(zea): implement in such a way that we can handle failures and the
- // subsequent retrys the scheduler might perform. See crbug.com/129665.
- NOTIMPLEMENTED();
- }
-
- // Only reconfigure if we have types to download.
+ // Only perform configure if we have types to download.
if (!params.types_to_download.Empty()) {
- DCHECK(!restricted_routes.empty());
linked_ptr<SyncSession> session(new SyncSession(
session_context_,
this,

Powered by Google App Engine
This is Rietveld 408576698