Issue 10455004: Making sure self-hosting and packaging docs are clear about keeping private key secure

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10455004: Making sure self-hosting and packaging docs are clear about keeping private key secure (Closed)

Created:
8 years, 7 months ago by mkearney

Modified:
8 years, 4 months ago

Reviewers:
Aaron Boodman, Erik does not do reviews

CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

More Reviews

Description

The self-hosting and packaging docs are not as clear as they should be about keeping the private key secure. This marks these docs as for advanced developers only, adds more reminders to keep the private key secure, and is more assertive in what the user needs (or doesn't need) to do.

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 1

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+74 lines, -26 lines)			Patch
M	chrome/common/extensions/docs/hosting.html	View	1 2 3	2 chunks	+10 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/docs/packaging.html	View	1 2 3	5 chunks	+27 lines, -13 lines	0 comments	Download
M	chrome/common/extensions/docs/static/hosting.html	View	1 2 3	1 chunk	+10 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/docs/static/packaging.html	View	1 2 3	4 chunks	+27 lines, -13 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Aaron Boodman

http://codereview.chromium.org/10455004/diff/2002/chrome/common/extensions/docs/static/packaging.html File chrome/common/extensions/docs/static/packaging.html (right): http://codereview.chromium.org/10455004/diff/2002/chrome/common/extensions/docs/static/packaging.html#newcode153 chrome/common/extensions/docs/static/packaging.html:153: However, a new extension ID will be created I ...

8 years, 6 months ago (2012-06-06 18:27:26 UTC) #1

Aaron Boodman

Old CL is old. Do you need help landing this Meggin?

8 years, 4 months ago (2012-08-06 23:36:48 UTC) #2

Aaron Boodman

8 years, 4 months ago (2012-08-10 21:38:58 UTC) #3

On 2012/08/06 23:36:48, Aaron Boodman wrote:
> Old CL is old. Do you need help landing this Meggin?

I've split this into two things:

https://chromiumcodereview.appspot.com/10825308/
crbug.com/141957

Expand Messages | Collapse Messages