Dispatch a new event chrome.contextMenus.onClicked.

chrome/browser/extensions/api/context_menu/context_menu_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/context_menu/context_menu_api.h"
 
 #include <string>
 
 #include "base/values.h"
 #include "base/string_number_conversions.h"
 #include "base/string_util.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/extensions/extension_error_utils.h"
 
 namespace {
 
 const char kCheckedKey[] = "checked";
 const char kContextsKey[] = "contexts";
 const char kDocumentUrlPatternsKey[] = "documentUrlPatterns";
 const char kEnabledKey[] = "enabled";
 const char kGeneratedIdKey[] = "generatedId";
 const char kIdKey[] = "id";
+const char kOnclickKey[] = "onclick";
 const char kParentIdKey[] = "parentId";
 const char kTargetUrlPatternsKey[] = "targetUrlPatterns";
 const char kTitleKey[] = "title";
 const char kTypeKey[] = "type";
 
 const char kCannotFindItemError[] = "Cannot find menu item with id *";
+const char kOnclickDisallowedError[] = "Extensions using event pages cannot "
+    "pass an onclick parameter to chrome.contextMenus.create";

[Matt Perry, 2012/06/01 01:57:15]

nit: add "Use the chrome.contextMenus.onClicked event instead"

[Yoyo Zhou, 2012/06/01 18:17:52]

Done.

 const char kCheckedError[] =
     "Only items with type \"radio\" or \"checkbox\" can be checked";
 const char kDuplicateIDError[] =
     "Cannot create item with duplicate id *";
 const char kIdRequiredError[] = "Extensions using event pages must pass an "
     "id parameter to chrome.contextMenus.create";
 const char kInvalidValueError[] = "Invalid value for *";
 const char kInvalidTypeStringError[] = "Invalid type string '*'";
 const char kParentsMustBeNormalError[] =
     "Parent items must have type \"normal\"";
@@ skipping 160 matching lines @@
 
   ExtensionMenuManager* menu_manager =
       profile()->GetExtensionService()->menu_manager();
 
   if (menu_manager->GetItemById(id)) {
     error_ = ExtensionErrorUtils::FormatErrorMessage(kDuplicateIDError,
                                                      GetIDString(id));
     return false;
   }
 
+  if (GetExtension()->has_lazy_background_page() &&
+      properties->HasKey(kOnclickKey)) {
+    error_ = kOnclickDisallowedError;
+    return false;
+  }
+
   ExtensionMenuItem::ContextList contexts(ExtensionMenuItem::PAGE);
   if (!ParseContexts(*properties, kContextsKey, &contexts))
     return false;
 
   ExtensionMenuItem::Type type;
   if (!ParseType(*properties, ExtensionMenuItem::NORMAL, &type))
     return false;
 
   if (title.empty() && type != ExtensionMenuItem::SEPARATOR) {
     error_ = kTitleNeededError;
@@ skipping 143 matching lines @@
 
 bool RemoveAllContextMenusFunction::RunImpl() {
   ExtensionService* service = profile()->GetExtensionService();
   ExtensionMenuManager* manager = service->menu_manager();
   manager->RemoveAllContextItems(GetExtension()->id());
   manager->WriteToPrefs(GetExtension());
   return true;
 }
 
 }  // namespace extensions