sync: Refactor per-datatype throttling

sync/internal_api/all_status.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // The AllStatus object watches various sync engine components and aggregates
 // the status of all of them into one place.
 
 #ifndef SYNC_INTERNAL_API_ALL_STATUS_H_
 #define SYNC_INTERNAL_API_ALL_STATUS_H_
 #pragma once
@@ skipping 33 matching lines @@
   virtual void OnSyncEngineEvent(const SyncEngineEvent& event) OVERRIDE;
 
   sync_api::SyncManager::Status status() const;
 
   void SetNotificationsEnabled(bool notifications_enabled);
 
   void IncrementNotifiableCommits();
 
   void IncrementNotificationsReceived();
 
+  void SetThrottledTypes(syncable::ModelTypeSet types);

[tim (not reviewing), 2012/06/11 18:53:46]

I'm not sure why SetEncryptedTypes doesn't use const& already, but we should
here (and there, most likely).

[rlarocque, 2012/06/11 23:28:51]

Done.  

I fixed SetEncryptedTypes, too.  I feel bad about merging an unrelated change
into this CL, but I doubt I would ever bother to fix it otherwise.

+
   void SetEncryptedTypes(syncable::ModelTypeSet types);
   void SetCryptographerReady(bool ready);
   void SetCryptoHasPendingKeys(bool has_pending_keys);
 
   void SetUniqueId(const std::string& guid);
 
  protected:
   // Examines syncer to calculate syncing and the unsynced count,
   // and returns a Status with new values.
   sync_api::SyncManager::Status CalcSyncing(const SyncEngineEvent& event) const;
   sync_api::SyncManager::Status CreateBlankStatus() const;
 
   sync_api::SyncManager::Status status_;
 
   mutable base::Lock mutex_;  // Protects all data members.
   DISALLOW_COPY_AND_ASSIGN(AllStatus);
 };
 
 class ScopedStatusLock {
  public:
   explicit ScopedStatusLock(AllStatus* allstatus);
   ~ScopedStatusLock();
  protected:
   AllStatus* allstatus_;
 };
 
 }  // namespace browser_sync
 
 #endif  // SYNC_INTERNAL_API_ALL_STATUS_H_