net/disk_cache/mapped_file_win.cc - Issue 10454093: Disk cache: Pre-read file headers when opening files (posix).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/disk_cache/mapped_file_win.cc

Issue 10454093: Disk cache: Pre-read file headers when opening files (posix). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/disk_cache/mapped_file_win.cc

===================================================================

--- net/disk_cache/mapped_file_win.cc (revision 138404)

+++ net/disk_cache/mapped_file_win.cc (working copy)

@@ -28,7 +28,7 @@

view_size_ = size;

// Make sure we detect hardware failures reading the headers.

- size_t temp_len = size ? size : 4096;

+ size_t temp_len = size ? size : 4096 * 2;

gavinp 2012/05/31 19:59:50 This is twice as good! Could we ever have a file

rvargas (doing something else) 2012/05/31 20:07:05 Nope, the header size is 8k.

scoped_array<char> temp(new char[temp_len]);

if (!Read(temp.get(), temp_len, 0))

return NULL;