Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1638)

Unified Diff: chrome/browser/metrics/metrics_service.cc

Issue 10454086: Histograms - Support histograms for Plugins, GPU (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/metrics_service.cc
===================================================================
--- chrome/browser/metrics/metrics_service.cc (revision 140625)
+++ chrome/browser/metrics/metrics_service.cc (working copy)
@@ -163,7 +163,6 @@
#include "chrome/browser/extensions/process_map.h"
#include "chrome/browser/io_thread.h"
#include "chrome/browser/memory_details.h"
-#include "chrome/browser/metrics/histogram_synchronizer.h"
#include "chrome/browser/metrics/metrics_log.h"
#include "chrome/browser/metrics/metrics_log_serializer.h"
#include "chrome/browser/metrics/metrics_reporting_scheduler.h"
@@ -184,6 +183,7 @@
#include "chrome/common/pref_names.h"
#include "chrome/common/render_messages.h"
#include "content/public/browser/child_process_data.h"
+#include "content/public/browser/histogram_synchronizer.h"
#include "content/public/browser/load_notification_details.h"
#include "content/public/browser/notification_service.h"
#include "content/public/browser/plugin_service.h"
@@ -1083,9 +1083,9 @@
base::StatisticsRecorder::CollectHistogramStats("Browser");
// Set up the callback to task to call after we receive histograms from all
- // renderer processes. Wait time specifies how long to wait before absolutely
- // calling us back on the task.
- HistogramSynchronizer::FetchRendererHistogramsAsynchronously(
+ // renderer/child processes. Wait time specifies how long to wait before
jam 2012/06/07 03:34:33 nit: just "child processes" since renderer is a ty
ramant (doing other things) 2012/06/07 23:39:25 Done.
+ // absolutely calling us back on the task.
+ content::HistogramSynchronizer::FetchHistogramsAsynchronously(
MessageLoop::current(), callback,
base::TimeDelta::FromMilliseconds(kMaxHistogramGatheringWaitDuration));
}

Powered by Google App Engine
This is Rietveld 408576698