ui: Use utility functions from base/win throughout.

ui/base/win/events_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <windowsx.h>
 
 #include "ui/base/events.h"
 
 #include "base/logging.h"
 #include "base/time.h"
@@ skipping 66 matching lines @@
          native_event.message == WM_SYSKEYDOWN ||
          native_event.message == WM_CHAR ||
          native_event.message == WM_KEYUP ||
          native_event.message == WM_SYSKEYUP;
 }
 
 // Returns a mask corresponding to the set of pressed modifier keys.
 // Checks the current global state and the state sent by client mouse messages.
 int KeyStateFlagsFromNative(const base::NativeEvent& native_event) {
   int flags = 0;
-  flags |= (GetKeyState(VK_MENU) & 0x80) ? ui::EF_ALT_DOWN : 0;
-  flags |= (GetKeyState(VK_SHIFT) & 0x80) ? ui::EF_SHIFT_DOWN : 0;
-  flags |= (GetKeyState(VK_CONTROL) & 0x80) ? ui::EF_CONTROL_DOWN : 0;
+  flags |= base::win::IsAltPressed() ? ui::EF_ALT_DOWN : ui::EF_NONE;

[tfarina, 2012/05/30 00:04:29]

this code is duplicated with GetModifiersFromKeyState() implemented in
ui/views/events/event_win.cc. But I can't use it here because ui/base/ can't
depend in ui/views.

Looks like we should move GetModifiersFromKeyState() from
ui/views/events/event.h to ui/base/win?

+  flags |= base::win::IsShiftPressed() ? ui::EF_SHIFT_DOWN : ui::EF_NONE;
+  flags |= base::win::IsCtrlPressed() ? ui::EF_CONTROL_DOWN : ui::EF_NONE;
 
   // Check key messages for the extended key flag.
   if (IsKeyEvent(native_event))
     flags |= (HIWORD(native_event.lParam) & KF_EXTENDED) ? ui::EF_EXTENDED : 0;
 
   // Most client mouse messages include key state information.
   if (IsClientMouseEvent(native_event)) {
     int win_flags = GET_KEYSTATE_WPARAM(native_event.wParam);
     flags |= (win_flags & MK_SHIFT) ? ui::EF_SHIFT_DOWN : 0;
     flags |= (win_flags & MK_CONTROL) ? ui::EF_CONTROL_DOWN : 0;
@@ skipping 205 matching lines @@
   if (accel.fVirt & FSHIFT)
     modifiers |= ui::EF_SHIFT_DOWN;
   if (accel.fVirt & FCONTROL)
     modifiers |= ui::EF_CONTROL_DOWN;
   if (accel.fVirt & FALT)
     modifiers |= ui::EF_ALT_DOWN;
   return modifiers;
 }
 
 }  // namespace ui